Skip to content

fix(core): pass null to avoid serialization error #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antfu merged 1 commit into from
May 11, 2026
Merged

fix(core): pass null to avoid serialization error #325

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/core/src/client/webcomponents/state/messages.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export function useMessages(context: DocksContext): Reactive<MessagesState> {

const entryMap = new Map<string, DevToolsMessageEntry>()
let isInitialFetch = true
let lastVersion: number | undefined
let lastVersion: number | null = null

async function updateMessages() {
const result = await context.rpc.call('devtoolskit:internal:messages:list', lastVersion)
Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/node/rpc/internal/messages-list.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export const messagesList = defineRpcFunction({
setup: (context) => {
const host = context.messages as unknown as DevToolsMessagesHost
return {
async handler(since?: number): Promise<MessagesListResult> {
async handler(since?: number | null): Promise<MessagesListResult> {
const currentVersion = (host as any)._clock as number

if (since == null) {
Expand Down
Loading