Skip to content

Remove kiss_fft from public headers #62

Open

Description

@ePirat

Currently kiss_fft headers are installed, thats not as trivial to change as some classes use kiss_fft_cpx and kiss_fftr_cfg types in their class private members, so without the kiss_fft headers the public headers for these classes would cause errors when included by API users.

The classes are:

  • AmbisonicBinauralizer
  • AmbisonicShelfFilters
  • Decorrelator

The most trivial way to solve this seems to be the PIMPL idiom, see https://en.cppreference.com/w/cpp/language/pimpl.html
It would also mean that adding or removing private members would no longer break ABI, making it a lot easier to maintain stable ABI in the future.

Activity

  1. added this to the v0.4.0 Release milestone on Nov 10, 2025
  2. ePirat commented on Nov 19, 2025

    @ePirat
    CollaboratorAuthor

    @jbkempf Should we postpone this to a later release, or do you want this done now so that we don't have to break ABI again soon-ish?

  3. jbkempf commented on Nov 20, 2025

    @jbkempf
    Collaborator

    @jbkempf Should we postpone this to a later release, or do you want this done now so that we don't have to break ABI again soon-ish?

    Make a release, and postpone this.

  4. removed this from the v0.4.0 Release milestone on Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions