Crypto: use VC_INLINE for the ARM CPU_Query helpers

[flatstik]

C99 inline without static does not emit a function body. On aarch64 at -O0/-Os, DetectArmFeatures() then fails to link:

undefined reference to CPU_QueryAES
undefined reference to CPU_QuerySHA2

This showed up building VeraCrypt 1.26.29 as an OpenWrt package for aarch64_generic (OpenWrt builds with -Os). The helpers now use VC_INLINE, like the other helpers in cpu.c (IsIntel, IsAMD, IsHygon).

Signed-off-by: Ville Takio ville+git@takio.fi

[BKPepe]

@idrassi sorry to bother you, but would you mind to take a look?

[flatstik]

Rebased onto current master (after #1896); still a one-line-per-function change in src/Crypto/cpu.c.

Reproduction on master a15c996 with the OpenWrt aarch64 toolchain (gcc 14.4, musl):

aarch64-openwrt-linux-musl-gcc -Os -std=gnu99 -I.. -I../Common -c cpu.c
aarch64-openwrt-linux-musl-nm cpu.o | grep ' U CPU_Query'
                 U CPU_QueryAES
                 U CPU_QuerySHA2

Same at -O0; at -O2 gcc happens to inline both calls, which is why it doesn't show up in the usual builds. With this change, cpu.o has no undefined CPU_Query* references at any of those levels.

[idrassi]

Please use VC_INLINE for both CPU_QueryAES and CPU_QuerySHA2, following the existing helpers in cpu.c. This resolves the linkage problem while preserving our established portability macro.

[flatstik]

Done, both now use VC_INLINE (c06d745, rebased on current master). Checked with the OpenWrt aarch64 toolchain at -O0, -Os and -O2: no undefined CPU_Query* references and no warnings.

[idrassi]

@flatstik After the VC_INLINE adjustment, I will approve this PR.

[idrassi]

Thank you for your contribution.