Skip to content

fix(parser): accept unterminated comments - #359

Open
anastygnome wants to merge 2 commits into
uutils:mainfrom
anastygnome:split/comments
Open

anastygnome wants to merge 2 commits into
uutils:mainfrom
anastygnome:split/comments

Conversation

@anastygnome

@anastygnome anastygnome commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Treat an unmatched opening parenthesis as a comment through end of input, matching GNU date.
  • Resolve empty and comment-only input to the beginning of today (midnight).
  • Add parser and builder regressions.

@codecov

codecov Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.91%. Comparing base (0612ea5) to head (b0af722).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #359      +/-   ##
==========================================
- Coverage   98.97%   98.91%   -0.07%     
==========================================
  Files          21       21              
  Lines        4696     4695       -1     
  Branches      143      139       -4     
==========================================
- Hits         4648     4644       -4     
- Misses         47       50       +3     
  Partials        1        1              
Flag Coverage Δ
macos_latest 98.91% <100.00%> (-0.07%) ⬇️
ubuntu_latest 98.91% <100.00%> (-0.07%) ⬇️
windows_latest 12.39% <9.09%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed

codspeed Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Merging this PR will not alter performance

1 warning

⚠️ 11 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

✅ 21 untouched benchmarks


Comparing anastygnome:split/comments (b0af722) with main (0612ea5)

Open in CodSpeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant