Skip to content

fix(offset): match GNU timezone behavior - #358

Open
anastygnome wants to merge 2 commits into
uutils:mainfrom
anastygnome:split/offset
Open

anastygnome wants to merge 2 commits into
uutils:mainfrom
anastygnome:split/offset

Conversation

@anastygnome

@anastygnome anastygnome commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Preserve named-zone provenance so local abbreviations retain DST-aware behavior when applicable.
  • Preserve uutils compatibility for named offsets including AEST, AEDT, ACST, ACDT, and AWST.
  • Parse and normalize larger numeric offsets safely, including overflow validation.
  • Keep fixed offsets anchored before relative adjustments.

@codspeed

codspeed Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Merging this PR will degrade performance by 7.62%

2 warnings

⚠️ 14 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

⚠️ 3 benchmarks with a significant change ran on different hardware

Their base and head results were measured on machines with a different CPU, core count or memory, so the changes might not come from the code. Run base and head on the same runner type.

Learn more about Macro Runners

See affected benchmarks

❌ 3 regressed benchmarks
✅ 18 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
❌ parse_datetime_with_tz_name 63 µs 72.9 µs -13.58%
❌ parse_epoch_timestamp 11.6 µs 12.3 µs -5.46%
❌ parse_iso_datetime_t_separator 40.1 µs 41.6 µs -3.5%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing anastygnome:split/offset (c7366d4) with main (0612ea5)

Open in CodSpeed

@codecov

codecov Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.92746% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 98.92%. Comparing base (0612ea5) to head (c7366d4).

Files with missing lines Patch % Lines
src/items/builder.rs 96.07% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #358      +/-   ##
==========================================
- Coverage   98.97%   98.92%   -0.06%     
==========================================
  Files          21       21              
  Lines        4696     4837     +141     
  Branches      143      151       +8     
==========================================
+ Hits         4648     4785     +137     
- Misses         47       51       +4     
  Partials        1        1              
Flag Coverage Δ
macos_latest 98.92% <97.92%> (-0.06%) ⬇️
ubuntu_latest 98.92% <97.92%> (-0.06%) ⬇️
windows_latest 13.23% <41.45%> (+0.83%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant