Repository navigation
performance improvements - #355
anastygnome wants to merge 12 commits into
Conversation
d8861cd to
afd20cd
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #355 +/- ##
==========================================
- Coverage 98.97% 98.73% -0.25%
==========================================
Files 21 17 -4
Lines 4696 4890 +194
Branches 143 159 +16
==========================================
+ Hits 4648 4828 +180
- Misses 47 61 +14
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Merging this PR will improve performance by 18.22%2 warnings
Performance Changes
Tip Curious why performance improved? Comment Comparing |
|
I really like you didn't touch tests :) |
|
I did ? |
well, I just rewrote the parser in place and rechecked every rule, want me to add some? |
8b8bcb7 to
60bac2b
Compare
24cb12a to
201ca9e
Compare
7998859 to
352c682
Compare
|
please remove the fixup! |
352c682 to
b9aae81
Compare
b9aae81 to
8e6b080
Compare
|
@sylvestre done |
e0f4d45 to
0d40353
Compare
Choose the date parser from the first character instead of trying every form.
Parse shared time and offset prefixes once to reduce backtracking in common ISO inputs.
Choose the keyword or numeric path from the first character instead of trying failed alternatives.
Route text and numeric ordinals separately before parsing either form.
Skip the separated-date parser when the input is clearly a compact ISO date.
Avoid unnecessary timestamp and timezone parser probes on common inputs.
Use the crate-level limit in year parsing instead of keeping a second copy.
0d40353 to
bfea048
Compare
Depends on #350