dd: short-circuit multiplier on zero factor - #14182
Open
MadeNavaneeth wants to merge 1 commit into
Open
Conversation
MadeNavaneeth
force-pushed
the
fix/dd-zero-factor
branch
from
August 27, 2026 14:29
f2b9aa8 to
d780d21
Compare
|
GNU testsuite comparison: |
When a zero factor appears in a multiplier expression (e.g. `00x999...`), GNU dd short-circuits and returns 0 without parsing the remaining factors. Our implementation parsed all factors first, so a huge number in a later factor could fail with "Value too large" even though the product is zero. Fix by checking the parsed value: if it is zero and not the last factor, return 0 immediately after showing the zero-multiplier warning. Fixes uutils#14160
MadeNavaneeth
force-pushed
the
fix/dd-zero-factor
branch
from
August 27, 2026 15:30
d780d21 to
19d8b0a
Compare
Contributor
|
And unbreak rhe ci :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a zero factor appears in a multiplier expression (e.g. count=00x999...), GNU dd short-circuits and returns 0 without parsing the remaining factors. Our implementation parsed all factors first, so a huge number in a later factor could fail with "Value too large" even though the product is zero.
Fix by checking the parsed value: if it is zero and not the last factor, return 0 immediately after showing the zero-multiplier warning.
Fixes #14160