pipes.rs: remove fcntl overhead from splice_unbounded#12422
Merged
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
|
GNU testsuite comparison: |
Merging this PR will not alter performance
Comparing Footnotes
|
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
86e6d60 to
794137d
Compare
cd7c004 to
d1225b5
Compare
nonontb
pushed a commit
to nonontb/coreutils
that referenced
this pull request
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Any splice error is discarded. So no benefit for conversion.
Closes #12419 .Fix one of a bool issue seen #12365 .
Also avoid fcntl for small input.