Skip to content

pipes.rs: remove fcntl overhead from splice_unbounded#12422

Merged
sylvestre merged 1 commit into
uutils:mainfrom
oech3:useless-conversion
May 23, 2026
Merged

pipes.rs: remove fcntl overhead from splice_unbounded#12422
sylvestre merged 1 commit into
uutils:mainfrom
oech3:useless-conversion

Conversation

@oech3
Copy link
Copy Markdown
Contributor

@oech3 oech3 commented May 21, 2026

Any splice error is discarded. So no benefit for conversion.
Closes #12419 .
Fix one of a bool issue seen #12365 .
Also avoid fcntl for small input.

@oech3 oech3 force-pushed the useless-conversion branch from 7e72bbc to efcabfe Compare May 21, 2026 13:06
@oech3 oech3 changed the title pipes.rs: simlify, fix unnecessary Result conversion pipes.rs: simplify, fix useless Result conversion May 21, 2026
@oech3 oech3 force-pushed the useless-conversion branch from efcabfe to 179ef18 Compare May 21, 2026 13:10
@oech3

This comment was marked as resolved.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 21, 2026

GNU testsuite comparison:

Skip an intermittent issue tests/date/date-locale-hour (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/misc/io-errors (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/rm/isatty (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/cut/cut-huge-range is now passing!

@oech3 oech3 marked this pull request as ready for review May 21, 2026 13:34
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 21, 2026

Merging this PR will not alter performance

✅ 319 untouched benchmarks
⏩ 46 skipped benchmarks1


Comparing oech3:useless-conversion (3790a76) with main (bd908f0)

Open in CodSpeed

Footnotes

  1. 46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@xtqqczze

This comment was marked as outdated.

@oech3

This comment was marked as outdated.

@oech3 oech3 marked this pull request as draft May 21, 2026 13:44
@oech3 oech3 force-pushed the useless-conversion branch 3 times, most recently from 86e6d60 to 794137d Compare May 21, 2026 14:26
@oech3 oech3 marked this pull request as ready for review May 21, 2026 14:48
@oech3 oech3 force-pushed the useless-conversion branch from 794137d to ef8429c Compare May 21, 2026 15:41
@oech3 oech3 force-pushed the useless-conversion branch 2 times, most recently from cd7c004 to d1225b5 Compare May 22, 2026 15:06
@oech3 oech3 changed the title pipes.rs: simplify, fix useless Result conversion pipes.rs: remove fcntl overhead from splice_unbounded May 22, 2026
@oech3 oech3 force-pushed the useless-conversion branch from d1225b5 to 3790a76 Compare May 22, 2026 15:10
@sylvestre sylvestre merged commit 4f9a39b into uutils:main May 23, 2026
171 checks passed
@oech3 oech3 deleted the useless-conversion branch May 23, 2026 08:15
nonontb pushed a commit to nonontb/coreutils that referenced this pull request May 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants