Skip to content

pipes.rs: deduplicate some code#12389

Closed
oech3 wants to merge 1 commit into
uutils:mainfrom
oech3:drain-dedup
Closed

pipes.rs: deduplicate some code#12389
oech3 wants to merge 1 commit into
uutils:mainfrom
oech3:drain-dedup

Conversation

@oech3
Copy link
Copy Markdown
Contributor

@oech3 oech3 commented May 19, 2026

Help #12387 and some my PRs.

@oech3 oech3 force-pushed the drain-dedup branch 2 times, most recently from c5f59c4 to 66aa789 Compare May 19, 2026 15:27
@oech3 oech3 changed the title pipes.rs: deduplicate some code pipes.rs: deduplicate some code & drop unused trait May 19, 2026
@oech3 oech3 marked this pull request as ready for review May 19, 2026 15:37
Comment thread src/uucore/src/lib/features/pipes.rs Outdated
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 19, 2026

GNU testsuite comparison:

Skip an intermittent issue tests/date/date-locale-hour (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tail/tail-n0f (fails in this run but passes in the 'main' branch)
Note: The gnu test tests/rm/many-dir-entries-vs-OOM is now being skipped but was previously passing.
Congrats! The gnu test tests/tail/pipe-f is now passing!
Note: The gnu test tests/env/env-signal-handler was skipped on 'main' but is now failing.
Skip an intermittent issue tests/pr/bounded-memory (was skipped on 'main', now failing)

Comment thread src/uucore/src/lib/features/pipes.rs Outdated
@oech3 oech3 force-pushed the drain-dedup branch 4 times, most recently from 974eaa7 to ea74b7b Compare May 19, 2026 19:11
@oech3 oech3 requested a review from xtqqczze May 19, 2026 19:12
@oech3 oech3 force-pushed the drain-dedup branch 2 times, most recently from 342e1a3 to 9accd08 Compare May 19, 2026 19:21
@oech3
Copy link
Copy Markdown
Contributor Author

oech3 commented May 19, 2026

Hmm... rustix::io::read does not work

Comment thread src/uucore/src/lib/features/pipes.rs Outdated
Comment thread src/uucore/src/lib/features/pipes.rs
@oech3 oech3 changed the title pipes.rs: deduplicate some code & drop unused trait pipes.rs: deduplicate some code May 20, 2026
@oech3 oech3 force-pushed the drain-dedup branch 2 times, most recently from 631b2ce to 3d91d5c Compare May 20, 2026 07:25
@oech3
Copy link
Copy Markdown
Contributor Author

oech3 commented May 20, 2026

I considered that std::io::copy breaks fuse, But input is actually pipe... Also We have Raw{Reader,Writer} to remove buffering from io::copy.

@oech3 oech3 marked this pull request as draft May 20, 2026 08:03
@oech3 oech3 closed this May 20, 2026
@oech3 oech3 deleted the drain-dedup branch May 20, 2026 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants