fix(sort): reject leading '+' in numeric (-n) sort#12350
Open
leno23 wants to merge 1 commit into
Open
Conversation
|
GNU testsuite comparison: |
GNU sort -n does not treat '+' as a number sign. Skip f64 parsing for lines with a leading plus so they sort lexicographically like GNU. Fixes uutils#10315
leno23
force-pushed
the
fix/sort-numeric-reject-plus-10315
branch
from
6fc6a33 to
3c80f3a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sort -ndoes not treat+as a number signf64fast-path parsing when a line begins with+after whitespaceFixes #10315
Test plan
test_numeric_sort_rejects_leading_plus_signMade with Cursor