Skip to content

fix(commands): preserve root frontmatter metadata - #3296

Open
kriptoburak wants to merge 1 commit into
ultraworkers:mainfrom
kriptoburak:codex/fix-nested-frontmatter
Open

fix(commands): preserve root frontmatter metadata#3296
kriptoburak wants to merge 1 commit into
ultraworkers:mainfrom
kriptoburak:codex/fix-nested-frontmatter

Conversation

@kriptoburak

Copy link
Copy Markdown
Contributor

Summary

  • Keep root Skill and agent metadata when nested YAML uses the same keys.
  • Add parser coverage and update the install example to a current portable Skill that exercises nested metadata.

Anti-slop triage

Verification

  • cd rust && cargo test -p commands --locked
  • cd rust && cargo test -p rusty-claude-cli --test output_format_contract skills --locked
  • cd rust && cargo clippy -p commands --all-targets --no-deps --locked -- -D warnings
  • python3 -m unittest discover -s tests
  • scripts/fmt.sh --check
  • python3 .github/scripts/check_doc_source_of_truth.py
  • python3 .github/scripts/check_release_readiness.py
  • git diff --check
  • No live secrets, tokens, private logs, or unrelated generated churn are included.

Resolution gate

@1716775457damn

Copy link
Copy Markdown

The fix direction makes sense — keeping root Skill/agent metadata authoritative over nested overrides matches the intended precedence, and adding parser coverage for a real-world Skill is a good regression guard. One question: for the case where a nested YAML genuinely should override (e.g. agent-specific tweaks), is there a documented/planned escape hatch, or is root-always-wins the deliberate contract? Either way, this closes the #3295 gap cleanly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

triage: nested frontmatter overrides Skill metadata

2 participants