Added duplicate field check and Google Sheet protections check. Creat… - #16
Added duplicate field check and Google Sheet protections check. Creat…#16bdgregg wants to merge 2 commits into
Conversation
…ed a separate script to check a Google Sheet for protections that hinder updating by the service account.
ctgraham
left a comment
There was a problem hiding this comment.
For Google Sheet checks, the standalone tool feels very duplicative to the added function in scan-batch-dir. It adds in additional human-readable description, but this could also be done by a common library, or by the scan-batch-dir calling the standalone tool and using machine readable outputs (e.g. exitcodes).
This isn't a request for changes necessarily, but rather a reminder to keep things DRY as a priority.
The duplicated column code is straightforward.
|
@ctgraham , Yes I agree the standalone tool is duplicative, but thought there might be times where we want to check this outside of scan-batch-dir. I agree that the functions could be added to a common library - when I get to that. |
|
One way to deduplicate the code would be to take in a command line argument of |
…ed a separate script to check a Google Sheet for protections that hinder updating by the service account.