feat(gateway): land and status subcommands for the client - #547
Open
behinddwalls wants to merge 1 commit into
Open
feat(gateway): land and status subcommands for the client#547behinddwalls wants to merge 1 commit into
behinddwalls wants to merge 1 commit into
Conversation
This was referenced Aug 7, 2026
behinddwalls
marked this pull request as ready for review
August 7, 2026 18:24
behinddwalls
force-pushed
the
sq/gateway-land-cli
branch
from
August 7, 2026 18:36
c97cdfb to
cc98ca9
Compare
behinddwalls
force-pushed
the
sq/gateway-land-cli
branch
from
August 7, 2026 21:21
cc98ca9 to
04c8f20
Compare
behinddwalls
force-pushed
the
sq/gateway-land-cli
branch
from
August 7, 2026 22:19
04c8f20 to
5214ae8
Compare
behinddwalls
force-pushed
the
sq/gateway-land-cli
branch
from
August 7, 2026 22:57
5214ae8 to
4866a17
Compare
behinddwalls
force-pushed
the
sq/gateway-land-cli
branch
from
August 7, 2026 23:24
4866a17 to
0c2e9cf
Compare
## Summary ### Why? The gateway client only knew how to ping. Submitting a change meant hand-assembling protobuf with grpcurl, including a 40-character commit SHA copied out of a pull request — which is both tedious and easy to get subtly wrong. ### What? `ping | land | status` subcommands. `land` takes repeated `-uri` flags, whose order is significant: several changes in one request are a stack, applied in the order given. `-pr <url>` resolves a pull request's head commit and mints the change URI, so nobody types a SHA. It dispatches on the change URL the same way the merger and the change provider dispatch on the URI scheme, rather than assuming one provider; GitHub is implemented, and adding another is a case beside it. Reading a public repository needs no token, and a 404 without one says so rather than reporting the pull request as missing. ## Test Plan ✅ `go build ./service/submitqueue/gateway/client` and `go vet`. ✅ Manually: `land -queue q` reports the missing-change error; `land -pr https://github.com/uber/cadence/pull/1` resolved against the live GitHub API and printed `github://github.com/cadence-workflow/cadence/pull/1/65c322d4...` before failing to dial a gateway, which is the expected end of that path with no stack running.
behinddwalls
force-pushed
the
sq/gateway-land-cli
branch
from
August 7, 2026 23:42
0c2e9cf to
c209e8d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why?
The gateway client only knew how to ping. Submitting a change meant hand-assembling protobuf with grpcurl, including a 40-character commit SHA copied out of a pull request — which is both tedious and easy to get subtly wrong.
What?
ping | land | statussubcommands.landtakes repeated-uriflags, whose order is significant: several changes in one request are a stack, applied in the order given.-pr <url>resolves a pull request's head commit and mints the change URI, so nobody types a SHA. It dispatches on the change URL the same way the merger and the change provider dispatch on the URI scheme, rather than assuming one provider; GitHub is implemented, and adding another is a case beside it. Reading a public repository needs no token, and a 404 without one says so rather than reporting the pull request as missing.Test Plan
✅
go build ./service/submitqueue/gateway/clientandgo vet.✅ Manually:
land -queue qreports the missing-change error;land -pr https://github.com/uber/cadence/pull/1resolved against the live GitHub API and printedgithub://github.com/uber/cadence/pull/1/65c322d4...before failing to dial a gateway, which is the expected end of that path with no stack running.Stack