Skip to content

Add missing tacks (part II)#174

Open
MDLC01 wants to merge 3 commits into
typst:mainfrom
MDLC01:tacks-p2
Open

Add missing tacks (part II)#174
MDLC01 wants to merge 3 commits into
typst:mainfrom
MDLC01:tacks-p2

Conversation

@MDLC01

@MDLC01 MDLC01 commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

This is a follow-up to #151.

Some of the names we use in this PR were made available for this purpose by the deprecations introduced in #151.

@MDLC01 MDLC01 changed the title Add even more missing (part II) Add missing tacks (part II) Jun 16, 2026
@MDLC01 MDLC01 added the waiting on reviews Breaking and non-breaking changes need respectively 3 and 2 reviews label Jun 16, 2026

@isuffix isuffix left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@MDLC01 MDLC01 removed the waiting on reviews Breaking and non-breaking changes need respectively 3 and 2 reviews label Jun 17, 2026
Comment thread CHANGELOG.md
## New in `sym`

- Miscellaneous technical
- `tack.r.double` ⊩

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes sense as is, but perhaps these should use a "Changed codepoint" section like we've done in the past, instead of being removed and added at the same time?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I don't like with a "Changed codepoints" section is that it buries what are effectively additions under a different part.

What about listing those in "New in sym" like now, but adding a "Changed codepoints" section as well?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not a bad idea. I'd actually want to move them there from the "Removals" then tho, i.e. have them in "New in sym" and in "Changed codepoints (breaking change)", but not in "Removals in sym (breaking change)"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants