feat: merge same-net collinear trace segments#562
Open
singhaditya21 wants to merge 3 commits into
Open
Conversation
Add mergeCollinearTraces() utility that groups traces by net, finds horizontal/vertical segments sharing the same constant coordinate, and merges overlapping or adjacent 1-D intervals into a single longer segment. This eliminates visual clutter from redundant same-net trace lines. Integrate the function into SchematicTracePipelineSolver.getOutput() so callers receive deduplicated traces without modifying the internal pipeline. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Renames mergeCollinearTraces.ts → merge-collinear-traces.ts and the corresponding test file to satisfy the repo's useFilenamingConvention biome rule. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Author
|
Friendly nudge 🙂 — CI is green and this is mergeable whenever you have a moment. Happy to rebase or address any feedback if it helps. Thanks for the great project! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #34
/claim #34
mergeCollinearTraces()inlib/utils/mergeCollinearTraces.tsthat groupsSolvedTracePathtraces byglobalConnNetId, finds horizontal/vertical segments sharing the same constant coordinate, and merges overlapping or adjacent 1-D intervals into a single longer segment.SchematicTracePipelineSolver.getOutput()so callers automatically receive deduplicated traces without any pipeline restructuring.How it works
The algorithm:
globalConnNetId.Test plan
bun test tests/functions/mergeCollinearTraces.test.ts— all 8 new tests passbunx tsc --noEmit— no type errorsbun test— all 79 pre-existing tests still pass (4 pre-existing skips; 1 unrelated pre-existing failure in an untracked file from another branch)🤖 Generated with Claude Code