fix(desktop): don't quit on arbitrary timer expiry - #618
Open
mikolysz wants to merge 1 commit into
Open
Conversation
wxdragon's Timer::on_tick binds its callback to the owning frame's wxEVT_TIMER without a timer id, so every timer's tick runs the closures of all other timers bound to the same frame. The sleep-timer closure closed the application unconditionally, which also caused it to close when any other timers fired. This bug was latent on master, as there were no other timers which could cause it to trigger. However, I have future PRS in the pipeline that do need additional timers, hence this fix.
Owner
|
Thanks for this! However, this hack makes me a bit uncomfortable. Would it be possible for you to investigate this issue upstream in wxDragon? |
Contributor
Author
|
Sure, will do.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wxdragon's
Timer::on_tickbinds its callback to the owning frame's wxEVT_TIMER without a timer id, so every timer's tick runs the closures of all other timers bound to the same frame. This is likely an upstream bug.The sleep-timer closure closed the application unconditionally, which also caused it to close when any other timers fired.
This bug was latent on master, as there were no other relevant timers which could cause it to trigger. However, I have future PRS in the pipeline that do need additional timers, hence this fix.