Repository navigation
Conversation
trypsynth
left a comment
There was a problem hiding this comment.
Thanks for this, it's in the right place under Screen on and off, and off by default is right. The problem is how wide the silence is.
Must fix
- It isn't limited to the lock screen, and it never times out. Suppression starts when the screen turns on and lasts until the first touch, gesture, key or navigation. So anything that turns the screen on by itself loses its window title and focus speech: the incoming call screen, alarms, timers and emergency alerts. After face unlock or Smart Lock, the home screen or app that appears is silent too. Please end suppression when the device unlocks, and after a short timeout as well.
- Emergency alerts. The change in
FocusManagerInternalremoves Google's comment that cell broadcast is an emergency announcement and must not be muted, and the new earlyreturn truenow mutes it. Please keep cell broadcast (and calls and alarms) out of this, and keep that comment. - Scope. Muting all window-change speech and focus events from every app is much wider than the S23 items you describe (carrier name, "Extend Unlock", "System UI", the last focused item). Limiting it to System UI and the lock screen would cover those without touching other apps.
Should fix
- It edits 7 of Google's files, including a signature change to
shouldMuteFeedbackForFocusedNodethat ripples into its callers. The focus check could live in one Backtalk-owned place, such as the focus listener inTalkBackService, which keeps future TalkBack merges easier. - "Suppress extra speech" is hard to understand on its own. Something like "Say only the items above" is clearer, and the switch fits better at the end of the category than the top.
- Please add Czech translations of the two strings to
values-cs/strings_backtalk.xml, like the other screen-on strings. - It was tested on one Samsung phone, and the System UI checks are aimed at Samsung's behaviour, so a test on a Pixel or another phone would help.
|
Thanks for the review. I've pushed the requested fixes. The option remains off by default, at the end of the screen-on category, and hidden/inactive on Wear OS. Changes addressing the maintainer's review:
Validation on the final PR branch, after bringing in current upstream:
Device evidence is separate from those automated results:
Pixel and other non-Samsung devices have not been tested. The Lineage OS result does not establish Pixel behavior. Physical Wear interaction was not tested. The PR contains only the screen-on feature; return-focus work, local debug-app configuration, APKs, and contributor guidance are excluded. |
On my Galaxy S23 Plus, turning the screen on could produce very verbose speech: the carrier name, Extend Unlock, System UI, and then the last focused item. This adds an optional way to make lock-screen wake speech simpler and less verbose.
Adds Say only the items above at the end of Verbosity > Screen on and off > When the screen turns on, off by default. It limits automatic lock-screen UI speech to the selected time and status announcements while still restoring focus. The separate Say "Device unlocked" setting remains independent. The option is hidden and inactive on Wear OS.
Changes addressing the maintainer's review:
Validation on the final PR branch, after bringing in current upstream:
testPhoneDebugUnitTest: 636 tests passed;:talkback:testWearDebugUnitTest: 378 tests passed.:lintPhoneDebug: passed, with no remaining lint errors.assemblePhoneDebug,assembleWearDebug, andgit diff --check: passed.Device evidence is separate from those automated results:
Pixel and other non-Samsung devices have not been tested. The Lineage OS result does not establish Pixel behavior. Physical Wear interaction was not tested.
The PR contains only the screen-on feature; return-focus work, local debug-app configuration, APKs, and contributor guidance are excluded.