Repository navigation
Name the reading control actions in the reading control hints - #130
Merged
Merged
Conversation
trypsynth
reviewed
Oct 9, 2026
trypsynth
left a comment
Owner
There was a problem hiding this comment.
Nice. The hints now name the gestures the user actually has, through the same lookup the gesture settings use, so RTL, watch defaults, other gesture sets and unassigned gestures all come out right. Thanks for fixing the cache that getAdjustSelectedSettingGestureNames wrote into, too.
This stacks on #123, so it can only merge after that one. A few small things for the reading control commit:
- Conflict with master. 29d6f13 ("Say the value when a reading control is at its limit") changed the same announcements for volume, brightness and both focus delays, and added the
@StringResimport. When rebasing, keep theatLimit(...)text along with the new hint. - Line separator. The two action lines are joined with
"\n".CompositorUtils.getSeparator()would match how the screen search hint joins its lines. - Line length. One line around
SelectorController.java:2207is 107 characters, over the 100 limit. - Optional:
actionLinescould move intoGestureHints, which would keep more of this out of Google's file.
Also worth knowing, not for this PR: the granularity and spell check hints still say "swipe up or swipe down to read by…" in the old style, so the two kinds of hint sound a bit different now.
aaron-gh
force-pushed
the
reading-control-hint
branch
from
October 9, 2026 15:59
d75ac74 to
64130a9
Compare
aaron-gh
added a commit
to aaron-gh/backtalk
that referenced
this pull request
Oct 9, 2026
Owner
|
Can you rebase now please? |
The hints for reading controls such as Brightness or Speech rate said "swipe up or swipe down to adjust the setting" on selecting one, and "swipe up with 3 fingers or swipe down with 3 fingers to select a different setting" after changing it, so after a change the hint said how to leave the reading control rather than how to change it. Once any hint for adjusting a reading control had been spoken, the second hint named the adjust gestures instead, as "swipe up or swipe down to select a different setting", because both used the same cache. Both hints now name the actions and their gestures, with the action titles from the gesture settings, which are translated: "Move reading control up or backward: Swipe up" and "Move reading control down or forward: Swipe down", on selecting and after changing a reading control. "No action available" on the Actions reading control, and "Spoken language unavailable while using a voice profile", name "Previous reading control" and "Next reading control" with their gestures. An action with no gesture names Backtalk settings > Gestures. Limitations: the hint doesn't name the reading control.
aaron-gh
force-pushed
the
reading-control-hint
branch
from
October 10, 2026 13:08
64130a9 to
c437295
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs #123, whose
GestureHintsthis uses; it contains that PR's commits until it's merged.The hints for reading controls such as Brightness or Speech rate said "swipe up or swipe down to adjust the setting" when you selected one, and "swipe up with 3 fingers or swipe down with 3 fingers to select a different setting" after you changed it. So after a change, the hint said how to leave the reading control rather than how to change it, and neither said what "the setting" was. Once any hint for adjusting a reading control had been spoken, such as "swipe up or swipe down to read by characters", the second hint named the adjust gestures instead: "swipe up or swipe down to select a different setting".
getAdjustSelectedSettingGestureNamessaved its gestures incachedSelectSettingGestureNames, the select gestures' cache.Both hints now name the actions with their gestures, using the action titles from the gesture settings, which are already translated: "Move reading control up or backward: Swipe up" and "Move reading control down or forward: Swipe down", on selecting and after changing a reading control. "No action available" on the Actions reading control, and "Spoken language unavailable while using a voice profile", name "Previous reading control" and "Next reading control" with their gestures. An action with no gesture names Backtalk settings > Gestures. The select gestures' cache, no longer used, is removed.
Limitations
The hint doesn't name the reading control.
Testing
On an Android 16 emulator: