Skip to content

chore(timescaledb): revert the timescaledb images - #4467

Merged
Crow-Control merged 1 commit into
mainfrom
revert/timescaledb-images
Nov 2, 2026
Merged

Crow-Control merged 1 commit into
mainfrom
revert/timescaledb-images

Conversation

@alfi0812

@alfi0812 alfi0812 commented Nov 2, 2026

Copy link
Copy Markdown
Member

Description
Reverts #4465. No chart in TrueCharts uses TimescaleDB, so the type: timescaledb feature is being removed from common, and these images are no longer needed.

This removes timescaledb15, timescaledb16, timescaledb17 and timescaledb18, and the exception for images based on CloudNativePG in dockerfile.instructions.md.

⚒️ Fixes #

⚙️ Type of change

  • 🧰 New container/image
  • 🛠️ Update existing container/image
  • 🐛 Bugfix (Dockerfile, scripts, chart values)
  • 🔃 Refactor (no functional change)
  • ⚠️ Breaking change (image tag, chart API change)

🧪 How Has This Been Tested?
Not tested, as this only removes the apps added by #4465.

  • ✅ Built container locally
  • ✅ Ran container tests (unit/integration)
  • ✅ Verified image in staging environment
  • ✅ Checked container logs for errors

📃 Notes
🤖 This PR is AI generated.

The published images stay in the registry, this does not delete or deprecate them.

✔️ Checklist:

  • ⚖️ Changes follow the style guidelines of this project
  • 👀 Self-review completed
  • ✍️ Dockerfile and scripts are clear and accurate
  • 🔗 Internal references (base images) are correct
  • 🧪 Test instructions included
  • 🏷️ The PR title follows the convention:
    • feat(page):
    • fix(content):
    • docs(site):
    • chore(site):

Please don't blindly check all the boxes. Read them and only check those that apply.
Those checkboxes are there for the reviewer to see what is this all about and
the status of this PR with a quick glance.

No chart uses TimescaleDB, so the feature is removed from common.

This reverts commit 68d456c.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Caution

Review failed

The pull request is closed.

Summary

Summary by CodeRabbit

  • Removed

    • TimescaleDB container images for PostgreSQL versions 15, 16, 17, and 18 are no longer available in this release.
    • Their associated configuration and container checks have also been removed. This affects building and running these images through the provided project setup.
  • Other Changes

    • Container image guidance no longer includes special requirements for CloudNativePG-based images; the general requirement to run as the apps user remains.

The pull request removes the TimescaleDB app definitions and supporting runtime files for PostgreSQL 15–18. It also removes the Dockerfile instruction exception for CloudNativePG-based images.

Changes: TimescaleDB app removal

Layer / File(s) Summary
Remove image build definitions
.github/instructions/dockerfile.instructions.md, apps/timescaledb{15,16,17,18}/Dockerfile, apps/timescaledb{15,16,17,18}/docker-bake.hcl
The Dockerfiles and Docker Bake configurations for TimescaleDB 15–18 were deleted. The CloudNativePG-specific Dockerfile instruction exception was removed.
Remove runtime settings and container tests
apps/timescaledb{15,16,17,18}/settings.yaml, apps/timescaledb{15,16,17,18}/start.sh, apps/timescaledb{15,16,17,18}/container-test.yaml
The settings, startup scripts, and container-test configurations for TimescaleDB 15–18 were deleted.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Possibly related PRs

Merge Risk: Minimal · up to 5a1e1

The removed apps are not required by the remaining build workflows or Dockerfile guidance. No actionable merge risk remains beyond normal checks.

- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@Crow-Control
Crow-Control merged commit 64f4fb1 into main Nov 2, 2026
4 of 5 checks passed
@Crow-Control
Crow-Control deleted the revert/timescaledb-images branch November 2, 2026 18:34
Crow-Control pushed a commit to trueforge-org/truecharts that referenced this pull request Nov 2, 2026
**Description**

Removes `dependencies.postgresql.operator.type: timescaledb`. No chart
in `charts/stable` or `charts/incubator` uses it, so its images are not
worth maintaining. On `master` it never worked without a chart providing
its own image either, as `common` had none.

- Remove `postgresTimescaledb15Image` to `postgresTimescaledb18Image`,
the `timescaledb` preload library and `CREATE EXTENSION`, and turning
off its telemetry.
- Remove `timescaledb` from the valid types, in the template and the
schema. It now fails rendering with the existing error for an invalid
type.
- Remove `ci/cnpg-pg18-timescaledb-values.yaml` and its install job.
- Update the schema, bundled schema, docs and tests. Two monitoring
tests that happened to use this type now use the default one.

The images themselves are reverted in trueforge-org/containerforge#4467.

Common is bumped to 31.0.1.

⚒️ Fixes  # n/a

**⚙️ Type of change**

- [ ] ⚙️ Feature/App addition
- [ ] 🪛 Bugfix
- [x] ⚠️ Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [x] 🔃 Refactor of current code
- [x] 📜 Documentation Changes

**🧪 How Has This Been Tested?**

`./run_common_tests.sh` on Helm v4.3.1: 1914 unit tests pass, schema
validation 856/856, schema coverage 100%, and the docs and bundled
schema checks pass. `type: timescaledb` fails rendering, and the default
type still renders its `Cluster`.

**📃 Notes:**

🤖 This PR is AI generated.

- A chart outside this repository that uses `type: timescaledb` with its
own image can't move to this version. `common` 31 has not been released
yet, so this is part of that major version.
- `timescaledb: false` in the values of `bitmagnet`, `blocky` and
`teslamate` is a Grafana datasource setting, and is not related.

**✔️ Checklist:**

- [x] ⚖️ My code follows the style guidelines of this project
- [x] 👀 I have performed a self-review of my own code
- [ ] #️⃣ I have commented my code, particularly in hard-to-understand
areas
- [x] 📄 I have made changes to the documentation
- [x] 🧪 I have added tests to this description that prove my fix is
effective or that my feature works
- [x] ⬆️ I increased versions for any altered app according to semantic
versioning
- [x] I made sure the title starts with `feat(chart-name):`,
`fix(chart-name):`, `chore(chart-name):`, `docs(chart-name):` or
`fix(docs):`

**➕ App addition**

If this PR is an app addition please make sure you have done the
following.

- [ ] 🖼️ I have added an icon in the Chart's root directory called
`icon.png`

---

_Please don't blindly check all the boxes. Read them and only check
those that apply.
Those checkboxes are there for the reviewer to see what is this all
about and
the status of this PR with a quick glance._

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Crow-Control pushed a commit to trueforge-org/truecharts that referenced this pull request Nov 3, 2026
**Description**

Removes `dependencies.postgresql.operator.type: timescaledb`. No chart
in `charts/stable` or `charts/incubator` uses it, so its images are not
worth maintaining. On `master` it never worked without a chart providing
its own image either, as `common` had none.

- Remove `postgresTimescaledb15Image` to `postgresTimescaledb18Image`,
the `timescaledb` preload library and `CREATE EXTENSION`, and turning
off its telemetry.
- Remove `timescaledb` from the valid types, in the template and the
schema. It now fails rendering with the existing error for an invalid
type.
- Remove `ci/cnpg-pg18-timescaledb-values.yaml` and its install job.
- Update the schema, bundled schema, docs and tests. Two monitoring
tests that happened to use this type now use the default one.

The images themselves are reverted in trueforge-org/containerforge#4467.

Common is bumped to 31.0.1.

⚒️ Fixes  # n/a

**⚙️ Type of change**

- [ ] ⚙️ Feature/App addition
- [ ] 🪛 Bugfix
- [x] ⚠️ Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [x] 🔃 Refactor of current code
- [x] 📜 Documentation Changes

**🧪 How Has This Been Tested?**

`./run_common_tests.sh` on Helm v4.3.1: 1914 unit tests pass, schema
validation 856/856, schema coverage 100%, and the docs and bundled
schema checks pass. `type: timescaledb` fails rendering, and the default
type still renders its `Cluster`.

**📃 Notes:**

🤖 This PR is AI generated.

- A chart outside this repository that uses `type: timescaledb` with its
own image can't move to this version. `common` 31 has not been released
yet, so this is part of that major version.
- `timescaledb: false` in the values of `bitmagnet`, `blocky` and
`teslamate` is a Grafana datasource setting, and is not related.

**✔️ Checklist:**

- [x] ⚖️ My code follows the style guidelines of this project
- [x] 👀 I have performed a self-review of my own code
- [ ] #️⃣ I have commented my code, particularly in hard-to-understand
areas
- [x] 📄 I have made changes to the documentation
- [x] 🧪 I have added tests to this description that prove my fix is
effective or that my feature works
- [x] ⬆️ I increased versions for any altered app according to semantic
versioning
- [x] I made sure the title starts with `feat(chart-name):`,
`fix(chart-name):`, `chore(chart-name):`, `docs(chart-name):` or
`fix(docs):`

**➕ App addition**

If this PR is an app addition please make sure you have done the
following.

- [ ] 🖼️ I have added an icon in the Chart's root directory called
`icon.png`

---

_Please don't blindly check all the boxes. Read them and only check
those that apply.
Those checkboxes are there for the reviewer to see what is this all
about and
the status of this PR with a quick glance._

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants