Repository navigation
chore(timescaledb): revert the timescaledb images - #4467
Merged
Merged
Conversation
No chart uses TimescaleDB, so the feature is removed from common. This reverts commit 68d456c. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. Summary
Merge Risk:
|
9 of 13 tasks
Crow-Control
pushed a commit
to trueforge-org/truecharts
that referenced
this pull request
Nov 2, 2026
**Description** Removes `dependencies.postgresql.operator.type: timescaledb`. No chart in `charts/stable` or `charts/incubator` uses it, so its images are not worth maintaining. On `master` it never worked without a chart providing its own image either, as `common` had none. - Remove `postgresTimescaledb15Image` to `postgresTimescaledb18Image`, the `timescaledb` preload library and `CREATE EXTENSION`, and turning off its telemetry. - Remove `timescaledb` from the valid types, in the template and the schema. It now fails rendering with the existing error for an invalid type. - Remove `ci/cnpg-pg18-timescaledb-values.yaml` and its install job. - Update the schema, bundled schema, docs and tests. Two monitoring tests that happened to use this type now use the default one. The images themselves are reverted in trueforge-org/containerforge#4467. Common is bumped to 31.0.1. ⚒️ Fixes # n/a **⚙️ Type of change** - [ ] ⚙️ Feature/App addition - [ ] 🪛 Bugfix - [x]⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected) - [x] 🔃 Refactor of current code - [x] 📜 Documentation Changes **🧪 How Has This Been Tested?** `./run_common_tests.sh` on Helm v4.3.1: 1914 unit tests pass, schema validation 856/856, schema coverage 100%, and the docs and bundled schema checks pass. `type: timescaledb` fails rendering, and the default type still renders its `Cluster`. **📃 Notes:** 🤖 This PR is AI generated. - A chart outside this repository that uses `type: timescaledb` with its own image can't move to this version. `common` 31 has not been released yet, so this is part of that major version. - `timescaledb: false` in the values of `bitmagnet`, `blocky` and `teslamate` is a Grafana datasource setting, and is not related. **✔️ Checklist:** - [x] ⚖️ My code follows the style guidelines of this project - [x] 👀 I have performed a self-review of my own code - [ ] #️⃣ I have commented my code, particularly in hard-to-understand areas - [x] 📄 I have made changes to the documentation - [x] 🧪 I have added tests to this description that prove my fix is effective or that my feature works - [x] ⬆️ I increased versions for any altered app according to semantic versioning - [x] I made sure the title starts with `feat(chart-name):`, `fix(chart-name):`, `chore(chart-name):`, `docs(chart-name):` or `fix(docs):` **➕ App addition** If this PR is an app addition please make sure you have done the following. - [ ] 🖼️ I have added an icon in the Chart's root directory called `icon.png` --- _Please don't blindly check all the boxes. Read them and only check those that apply. Those checkboxes are there for the reviewer to see what is this all about and the status of this PR with a quick glance._ Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Crow-Control
pushed a commit
to trueforge-org/truecharts
that referenced
this pull request
Nov 3, 2026
**Description** Removes `dependencies.postgresql.operator.type: timescaledb`. No chart in `charts/stable` or `charts/incubator` uses it, so its images are not worth maintaining. On `master` it never worked without a chart providing its own image either, as `common` had none. - Remove `postgresTimescaledb15Image` to `postgresTimescaledb18Image`, the `timescaledb` preload library and `CREATE EXTENSION`, and turning off its telemetry. - Remove `timescaledb` from the valid types, in the template and the schema. It now fails rendering with the existing error for an invalid type. - Remove `ci/cnpg-pg18-timescaledb-values.yaml` and its install job. - Update the schema, bundled schema, docs and tests. Two monitoring tests that happened to use this type now use the default one. The images themselves are reverted in trueforge-org/containerforge#4467. Common is bumped to 31.0.1. ⚒️ Fixes # n/a **⚙️ Type of change** - [ ] ⚙️ Feature/App addition - [ ] 🪛 Bugfix - [x]⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected) - [x] 🔃 Refactor of current code - [x] 📜 Documentation Changes **🧪 How Has This Been Tested?** `./run_common_tests.sh` on Helm v4.3.1: 1914 unit tests pass, schema validation 856/856, schema coverage 100%, and the docs and bundled schema checks pass. `type: timescaledb` fails rendering, and the default type still renders its `Cluster`. **📃 Notes:** 🤖 This PR is AI generated. - A chart outside this repository that uses `type: timescaledb` with its own image can't move to this version. `common` 31 has not been released yet, so this is part of that major version. - `timescaledb: false` in the values of `bitmagnet`, `blocky` and `teslamate` is a Grafana datasource setting, and is not related. **✔️ Checklist:** - [x] ⚖️ My code follows the style guidelines of this project - [x] 👀 I have performed a self-review of my own code - [ ] #️⃣ I have commented my code, particularly in hard-to-understand areas - [x] 📄 I have made changes to the documentation - [x] 🧪 I have added tests to this description that prove my fix is effective or that my feature works - [x] ⬆️ I increased versions for any altered app according to semantic versioning - [x] I made sure the title starts with `feat(chart-name):`, `fix(chart-name):`, `chore(chart-name):`, `docs(chart-name):` or `fix(docs):` **➕ App addition** If this PR is an app addition please make sure you have done the following. - [ ] 🖼️ I have added an icon in the Chart's root directory called `icon.png` --- _Please don't blindly check all the boxes. Read them and only check those that apply. Those checkboxes are there for the reviewer to see what is this all about and the status of this PR with a quick glance._ Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reverts #4465. No chart in TrueCharts uses TimescaleDB, so the
type: timescaledbfeature is being removed fromcommon, and these images are no longer needed.This removes
timescaledb15,timescaledb16,timescaledb17andtimescaledb18, and the exception for images based on CloudNativePG indockerfile.instructions.md.⚒️ Fixes #
⚙️ Type of change
🧪 How Has This Been Tested?
Not tested, as this only removes the apps added by #4465.
📃 Notes
🤖 This PR is AI generated.
The published images stay in the registry, this does not delete or deprecate them.
✔️ Checklist:
feat(page):fix(content):docs(site):chore(site):Please don't blindly check all the boxes. Read them and only check those that apply.
Those checkboxes are there for the reviewer to see what is this all about and
the status of this PR with a quick glance.