[codex] Expose TUS upload chunk size#44
Draft
tim-kos wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
tusUploadChunkSizeto the Transloadit initializers and passes it through to TUSKit.0to let TUSKit upload each file in one request, which can be useful for iOS background uploads where scheduling a new task for each 500 KiB chunk can stall.createAssembly(... andUpload ..., completion:)fires after the Assembly is created and uploads are scheduled, not after file upload or processing completion.TransloaditFileDelegate.didFinishUploadfor upload completion andpollAssemblyStatusfor processing completion.Why
A customer using TransloaditKit 3.5.0 saw
didFinishUpload()fire while API2 had already aborted the Assembly after seeing only three default TUS chunks. Exposing the chunk size gives apps a way to avoid many small background URLSession tasks, and the docs now make the upload lifecycle explicit.Validation
swift test