CL-2954: Update datafeed tutorial#156
Conversation
SimonMorda
left a comment
SimonMorda
left a comment
There was a problem hiding this comment.
Added comment as Simon instead of Romain but didn't want to switch user and restart again.
| @@ -0,0 +1,236 @@ | |||
| import { | |||
There was a problem hiding this comment.
Im aware you've explained in other md files the purpose of this file but could you at least add an intro at the very top of the file to quickly indicate what's that file for while inviting people to read the README & INTEGRATION files?
There was a problem hiding this comment.
Added a short description/header
| const alertIndex = activeAlerts.findIndex( | ||
| alert => alert.id === id | ||
| ); | ||
| if (alertIndex === -1) return; |
There was a problem hiding this comment.
Even though the setTimeout is very small I would move this block down into it. activeAlerts may be different between now and within the setTimeout resulting in out of date data.
There was a problem hiding this comment.
Used codex and moved the alert lookup inside the timeout and now resolve by id against the latest activeAlerts state before updating.
| const price = lastPlusClickPrice; | ||
| const alertAction = actionsFactory.createAction({ | ||
| actionId: 'create_custom_alert', | ||
| label: `Add Alert at ${price.toFixed(2)}`, |
There was a problem hiding this comment.
Possible refinement to bring here at some point.
Depending on the formater used/precision set in Settings, toFixed may be wrong.
Not the end of the world though.
There was a problem hiding this comment.
Codex replaced toFixed with helped function that falls back to toFixed. I think this helped is not working so it will always fall back to toFixed(). I will look into it more in the future
|
Really good tutorial! I think some tweaks could be brought to centralize some common logic, especially when it comes to creating and managing web socket creation. |
|
@illetid , @SlicedSilver could you also please provide your feedback? 🙏 |
| @@ -0,0 +1,323 @@ | |||
| // Downloads private TradingView GitHub packages into vendor/tradingview and | |||
There was a problem hiding this comment.
[minor] we can try to use the library as a dependency in package.json and then we need just one manual step to copy the library files to the public folder in post-install. https://www.tradingview.com/charting-library-docs/latest/quick-start/#2-install-the-library
But it's really up to you
There was a problem hiding this comment.
I just checked and we don't have any bundler, so it will require a lot of additional setup. please ignore the comment above
|
QA tested it and it's moved to deploy column https://tradingview-air.atlassian.net/browse/CL-2954 |
You can merge it ✅ |
5 participants
No description provided.