Conversation
What was broken On desktop profiles with reviewer and copilot roles, the Copilot pill began 40px to the left of the Member Stats card. Root cause (if identifiable) The role pills use an equal grid with a 16px gap, while TCO and Member Stats use an asymmetric flex row with a 32px gap. The independent layouts produced different second-column offsets. What was changed Inset only the second role card by 40px when both the desktop and two-column container thresholds are met, preserving its right edge and leaving single-role and stacked layouts unchanged. Any added/updated tests Added a stylesheet regression assertion for the guarded desktop second-card alignment. All 80 Profiles tests, lint, and the production build pass. The full repository suite was also run; 18 unrelated suites fail in areas untouched by this ticket.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
On desktop profiles with reviewer and copilot roles, the Copilot pill began 40px to the left of the Member Stats card.
Root cause (if identifiable)
The role pills use an equal grid with a 16px gap, while TCO and Member Stats use an asymmetric flex row with a 32px gap. The independent layouts produced different second-column offsets.
What was changed
Inset only the second role card by 40px when both the desktop and two-column container thresholds are met. This preserves the shared right edge and leaves single-role and stacked layouts unchanged.
Any added/updated tests
Added a stylesheet regression assertion for the desktop and container guards plus the second-card offset.
yarn test:no-watch --runInBand --silent src/apps/profiles/src: passed, 16 suites and 80 tests.yarn lint: passed.yarn run build: passed with existing warnings.yarn test:no-watch: run; 211 suites and 1,021 tests passed, while 18 unrelated suites and 32 tests failed in Engagements, Payments, Wallet Admin, and Challenge Editor areas untouched by this ticket.