Conversation
What was broken New work-app challenges enabled winning-submission downloads for all registrants, including Development challenges that should restrict access to passing submitters. Root cause The new-challenge creation payload hard-coded the download-access metadata to true instead of deriving it from the selected challenge track. What was changed Defaulted Development challenges to passing-submitter access while preserving all-registrant access for Design and other tracks. Reused normalized Development-track detection and updated the existing field documentation. Any added/updated tests Added creation-payload regression cases verifying Design persists true and Development persists false.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
New work-app challenges enabled winning-submission downloads for all registrants, including Development challenges that should restrict access to passing submitters.
Root cause
The new-challenge creation payload hard-coded the download-access metadata to true instead of deriving it from the selected challenge track.
What was changed
Development challenges now default to passing-submitter access. Design and other challenge tracks retain all-registrant access, and the existing field documentation now describes the track-specific defaults.
Any added/updated tests
Added creation-payload regression cases verifying Design persists true and Development persists false. The ticket-specific tests, lint, and production build pass.
The full test command was also run. It reports 18 failing suites and 32 failing tests that were independently reproduced with identical counts on origin/dev; those existing failures cover module aliases, AI review mocks, approval/launch behavior, and other areas unrelated to PM-5825.