Conversation
What was broken Design challenge reviewers could select a Submission Place rating from 1 through 10 without any explanation that higher ratings represent better placements. Root cause The Submission Place question used the same generic scale selector as every other scorecard question, so the UI did not communicate the placement mapping. What was changed Added the 10-to-3 placement mapping and the 2-and-1 no-placement guidance below the Answer selector. The guidance is limited to Design-track SCALE questions named Submission Place. Any added/updated tests Added focused component coverage for the Design Submission Place case and negative coverage for non-Design challenges and unrelated scorecard questions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
Design challenge reviewers could select a Submission Place rating from 1 through 10 without any explanation that higher ratings represent better placements. This made it natural to mistake 1 for first place.
Root cause
The Submission Place question used the same generic scale selector as every other scorecard question, so the UI did not communicate the placement mapping.
What was changed
Added the complete placement mapping below the Answer selector: 10 is first place through 3 as eighth place, while 2 and 1 mean no placement. The guidance is shown only for Design-track SCALE questions named Submission Place.
Any added/updated tests
Added focused component coverage confirming the guidance appears for the Design Submission Place case and stays hidden for non-Design challenges and unrelated design scorecard questions.
Validation:
yarn test:no-watch src/apps/review --runInBand— passed, 50 suites and 177 tests.yarn lint— passed.yarn run build— passed with existing repository warnings.yarn test:no-watch— 212 of 230 suites and 1,023 of 1,055 tests passed. The remaining failures are unrelated existing wallet/work-app alias and expectation failures; representative failures reproduce in the untouched checkout.