Skip to content

PM-5787: Allow deferred screener assignment - #2114

Merged
jmgasper merged 1 commit into
devfrom
PM-5787
Aug 10, 2026
Merged

PM-5787: Allow deferred screener assignment#2114
jmgasper merged 1 commit into
devfrom
PM-5787

Conversation

@jmgasper

@jmgasper jmgasper commented Aug 9, 2026

Copy link
Copy Markdown
Collaborator

What was broken

Design challenges could not be saved as drafts or launched unless a Screener member was assigned to the standard Screening phase up front.

Root cause

Closed-opportunity reviewer validation and the member input required state treated Screening like every other human review phase.

What was changed

  • Kept the standard Screening reviewer configuration, phase, scorecard, and reviewer count required.
  • Allowed only its member assignment slots to remain empty so a copilot can assign the Screener later.
  • Preserved required assignments for Review, Checkpoint Screening, and other closed manual review phases.
  • Matched both phase template IDs and legacy phase instance IDs.
  • Updated the Challenge Editor documentation.

Any added/updated tests

  • Added schema coverage for deferred standard Screening assignment and retained Checkpoint Screening validation.
  • Added launch and Save as Draft coverage for a Design challenge without an assigned Screener.
  • Added reviewer UI coverage confirming that only standard Screening member inputs are optional.
  • PM-5787 focused tests, lint, and the production build pass.
  • The full repository test command was run: 211 suites and 1,025 tests passed; 18 unrelated pre-existing suites failed because of stale approval fixtures, missing mocks, and unresolved test aliases.

What was broken

Design challenges could not be saved as drafts or launched unless a Screener member was assigned to the standard Screening phase up front.

Root cause

Closed-opportunity reviewer validation and required input state treated Screening like every other human review phase.

What was changed

Kept the Screening phase configuration and scorecard required while allowing its member slots to remain empty, including for legacy phase instance IDs. Other review phases and Checkpoint Screening remain unchanged.

Any added/updated tests

Added schema, form save and launch, and reviewer UI coverage for optional standard Screening assignment and retained required behavior.
@jmgasper
jmgasper requested a review from kkartunov as a code owner August 9, 2026 22:16
@jmgasper
jmgasper merged commit 9a66dd5 into dev Aug 10, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant