Conversation
What was broken The challenge header stayed at 0% while completed Checkpoint Review, Checkpoint Screening, or Screening work was visible in the active phase. Root cause The header progress calculation always consumed final Review rows, so phase-specific screening and checkpoint review assignments never contributed to the percentage. What was changed Made review progress select the rows for the current or open review-like phase, including an open-phase fallback when the challenge has no current phase label. Counted COMPLETED and SUBMITTED screening-style assignments, including individual assignments within multi-screener rows, while preserving existing final Review filtering. Any added/updated tests Added unit coverage for completed Checkpoint Review, partial Checkpoint Screening, open-phase fallback, and multi-screener Screening progress. All 177 Review app tests pass. The full monorepo suite was also run and retains unrelated failures outside the Review app.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
The challenge header stayed at 0% while completed Checkpoint Review, Checkpoint Screening, or Screening work was visible in the active phase.
Root cause
The header progress calculation always consumed final Review rows. The UI already built separate phase-specific rows, but screening and checkpoint assignments never contributed to the displayed percentage.
What was changed
COMPLETEDandSUBMITTEDscreening-style assignments, including individual assignments in multi-screener rows.Any added/updated tests
yarn test:no-watch --runTestsByPath src/apps/review/src/lib/utils/reviewProgress.spec.ts: 6 tests passed.yarn test:no-watch --testPathPattern=src/apps/review/src: 49 suites and 177 tests passed.yarn lint: passed.yarn run build: passed with existing warnings.yarn test:no-watch: 1,023 of 1,055 tests passed; 32 existing failures remain in 18 unrelated suites outside the Review app.