Repository navigation
feat(storage): support soft delete in createBucket - #421
Merged
designcode merged 3 commits intoNov 18, 2026
Merged
designcode merged 3 commits into
designcode merged 3 commits into
Conversation
Contributor
[Medium impact] The reviewed changes appear safe to merge; no blocking issues were found. SummaryAdds soft delete at bucket creation in the storage SDK and exposes it through
No new actionable issues found. The earlier test concern is addressed by checking the bucket by name instead of searching one listing page. Reviews (3) · Last reviewed commit: "feat(cli): support soft delete when crea..." · Reviewed by Greptile |
createBucket accepts a softDelete option, sent as X-Tigris-Soft-Delete with the retention period in days on the CreateBucket request, so soft delete is enabled atomically with creation. retentionDays is validated to be a whole number between 7 and 90 before any request is sent. Move the soft delete shape into a shared BucketSoftDelete type, used by createBucket, updateBucket and getBucketInfo. Refs: TIG-12669 Assisted-by: Claude Fable 5.2 via Claude Code Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Biome 2.6.8 (#405) formats four markdown files differently, which fails the repo-wide check. Bump the config schema with biome migrate and apply the formatter's fixes. Assisted-by: Claude Fable 5.2 via Claude Code Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
designcode
force-pushed
the
aibrahim/tig-12669-support-setting-soft-delete-when-creating
branch
from
November 17, 2026 16:09
d80591e to
357db63
Compare
tahakhan
approved these changes
Nov 17, 2026
Add --soft-delete and --retention-days to `buckets create`, passed to createBucket so soft delete is set on the create request. Refs: TIG-12669 Assisted-by: Claude Opus 5.5 via Claude Code Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
designcode
deleted the
aibrahim/tig-12669-support-setting-soft-delete-when-creating
branch
November 18, 2026 11:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
createBucketcan now enable soft delete when the bucket is created, so the console can use the SDK for its create-bucket call. The CLI exposes it ontigris buckets create.createBucket: newsoftDeleteoption ({ enabled: true, retentionDays }), sent asX-Tigris-Soft-Delete: <retentionDays>on the CreateBucket request. Soft delete is enabled atomically with creation; there is no follow-up update.retentionDaysmust be a whole number between 7 and 90, checked before any request is sent.BucketSoftDeleteinbucket/types.ts, used bycreateBucket,updateBucketandgetBucketInfo, and exported from the package.tigris buckets create my-bucket --soft-delete --retention-days 30.--retention-daysis required with--soft-deleteand rejected without it. Not added totigris mk.@tigrisdata/storageand@tigrisdata/cli).The console sends
"true"for the default 7 days and the number otherwise. The SDK always sends the number, so the result does not depend on the server's default.Testing
getBucketInfo, and check that an out-of-range value creates no bucket (looked up by name).createBucketand each validation error. A CLI integration test creates a bucket with--soft-delete --retention-days 30and checksbuckets get; it was skipped locally (no access keys), so CI is its first run.Also in this PR
A separate commit bumps the Biome config schema to 2.6.8 (
biome migrate) and applies the formatter's fixes to four markdown files. Since #405,biome checkfails onmainwithout it, which blocks the pre-commit hook.Refs: TIG-12669
🤖 Generated with Claude Code
Note
Medium Risk
Changes bucket creation semantics and retention configuration, but behavior is additive, validated client-side, and covered by new unit and integration tests.
Overview
Buckets can now be created with soft delete enabled in one step, instead of only via
updateBucketafter the fact.@tigrisdata/storage:createBucketaccepts asoftDeleteoption using the new sharedBucketSoftDeletetype (also used byupdateBucketandgetBucketInfo). When enabled, retention is applied on the CreateBucket request viaX-Tigris-Soft-Delete: <days>(no follow-up update). Values outside 7–90 whole days are rejected before any request is sent.@tigrisdata/cli:tigris buckets creategains--soft-deleteand--retention-dayswith the same validation and wiring intocreateBucket. Docs/specs/examples and unit plus CLI integration tests cover the happy path and flag combinations.Minor changesets bump both packages. Biome’s schema is updated to 2.6.8 with markdown formatting fixes in several docs (including CLI README whitespace for Examples sections).
Reviewed by Cursor Bugbot for commit 724571b. Bugbot is set up for automated code reviews on this repo. Configure here.