fix(frost/signing): gate RFC-21 Phase 1B binding with frost_native build tag#3965
Merged
mswilkison merged 1 commit intoMay 22, 2026
Conversation
…ild tag The Phase 1B helpers and tests reference the three protocol-message structs (nativeFROSTRoundOneCommitmentMessage, nativeFROSTRoundTwoSignatureShareMessage, buildTaggedTBTCSignerRoundContributionMessage) which are themselves declared in files with //go:build frost_native. Without a matching build tag, the untagged staticcheck pass on the integration branch reports "undefined: nativeFROSTRoundOneCommitmentMessage" etc., and the lint job fails. Add //go:build frost_native to both the binding implementation file and its test. The helpers were only ever exercised from gated code paths, so the gate is the correct locus. Verified locally: * go build ./... * go build -tags 'frost_native frost_tbtc_signer' ./pkg/frost/... * go test -tags 'frost_native frost_tbtc_signer' ./pkg/frost/signing/ * staticcheck -checks "-SA1019" ./... (silent) This is a forward-fix for #3866 CI after the rapid merge train of #3963 and #3964.
mswilkison
merged commit ea16280
into
feat/frost-schnorr-migration-scaffold
14 checks passed
mswilkison
deleted the
fix/frost-readiness-phase1b-test-build-tag-2026-05-22
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Forward-fix for #3866 CI: the Phase 1B binding file and test
referenced message types defined in `//go:build frost_native`
files but were themselves untagged. Untagged staticcheck on
the integration branch (#3866) then reported
`undefined: nativeFROSTRoundOneCommitmentMessage` and the
client-lint job failed.
Adds `//go:build frost_native` to:
The helpers and tests are only exercised by gated code paths
(the three message-type methods all live behind `frost_native`),
so the build tag is the right locus.
Why now
PRs #3963 (Phase 1A) and #3964 (Phase 1B) were merged into the
`feat/frost-schnorr-migration-scaffold` branch before #3866's
integration CI ran. Once the merges landed, #3866's
`client-lint` job rebuilt under the untagged staticcheck pass
and exposed the missing tag. This PR is the smallest possible
fix.
Verification
Locally with module-pinned staticcheck 2025.1.1:
```
go build ./...
go build -tags 'frost_native frost_tbtc_signer' ./pkg/frost/...
go test -tags 'frost_native frost_tbtc_signer' ./pkg/frost/signing/
staticcheck -checks "-SA1019" ./... # whole repo, silent
staticcheck -checks "-SA1019" ./pkg/frost/signing # silent
```
Test plan
client-build-test-publish all pass.
`feat/frost-schnorr-migration-scaffold`.