tools: ctl: bound csv data write against abi header size#10977
Open
jmestwa-coder wants to merge 1 commit into
Open
tools: ctl: bound csv data write against abi header size#10977jmestwa-coder wants to merge 1 commit into
jmestwa-coder wants to merge 1 commit into
Conversation
The ascii csv branch of read_setup() advances the write index past the 32-byte abi header for -r (no_abi) input but still bounds each write with n < n_max, while the binary branch stops at n_max - abi_size. A csv tuning file with ctrl_size/4 values then writes sizeof(struct sof_abi_hdr) bytes past the end of the tlv buffer. Bound the csv write the same way. Signed-off-by: Syed Mohammed Nayyar <jmestwa@gmail.com>
Collaborator
|
Can one of the admins verify this patch?
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ascii csv input in read_setup() overflows the tlv buffer with -r:
Bounded the csv write with n < n_max - abi_size like the binary branch.