Conversation
Permission-denied .env paths no longer abort find_dotenv/load_dotenv; discovery continues to parent directories instead (issue theskumar#576).
| if os.access(self.dotenv_path, os.R_OK): | ||
| try: | ||
| with open(self.dotenv_path, encoding=self.encoding) as stream: | ||
| yield stream |
Contributor
There was a problem hiding this comment.
Yielding again here after except catches a thrown exception raises RuntimeError: generator didn't stop after throw(), not that original error from reading a stream.
Author
There was a problem hiding this comment.
Fixed in f6f09d6: the PermissionError handler now covers only open(), so exceptions from reading the yielded stream propagate unchanged. Added regression tests for open failure and read failure; the read test fails on the previous head with the RuntimeError you identified. Full suite: 262 passed; Ruff check passed.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #576.
When a
.envfile exists but is not readable (e.g. firejail orchmod 000),find_dotenv()previously returned that path andload_dotenv()/dotenv_values()raisedPermissionError. Discovery and load now treat unreadable paths as absent:find_dotenv()continues walking parent directories, and an explicit unreadable path yields an empty result instead of crashing.Test plan
test_find_dotenv_skips_unreadable_and_continuesfails on main, passes with this changetest_load_dotenv_unreadable_file_does_not_raisefails on main, passes with this changepytest— 260 passedruff check/ruff format --checkclean on touched files