Repository navigation
feat: Let callers hand over the HTTP client, and give up connecting after 10 seconds by default. - #8
Merged
Merged
Conversation
… as Java package. Wherever a registry requires a namespace, the client SDKs and the image of EventSourcingDB use thenativeweb: Packagist, Go modules, Docker Hub. Maven requires one, so the artifacts are now io.thenativeweb:eventsourcingdb and io.thenativeweb:eventsourcingdb-testcontainers. The Java packages follow the group ID, as is the convention in Java, and are now io.thenativeweb.eventsourcingdb and its testcontainers subpackage. Nothing has been published yet, so no caller is affected. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Hc2MPSLu7HDHTm8HiBsrDz
…NullAway. Java can not say whether a value may be null. Both packages are now @NullMarked, so everything is non-null unless it is marked @nullable, as the optional fields of EventCandidate and of the options are. Kotlin reads these annotations, and Spring Boot 4 uses them, too. NullAway checks the code against the annotations as part of the build, and runs as the only check of Error Prone. Making LineStream pass it made explicit that it reads only once it has opened its stream. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Hc2MPSLu7HDHTm8HiBsrDz
…fter 10 seconds by default. The client created an HTTP client of its own that nobody could configure, without a timeout for connecting, a proxy, or TLS. An unreachable server left a request waiting for the timeout of the operating system. A Client now takes ClientOptions, whose HTTP client it sends requests with if one is given. It does not close that HTTP client, since it belongs to the caller. The HTTP client it creates otherwise gives up connecting after 10 seconds. There is deliberately no timeout for whole requests, since it would end every stream that observes events. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Hc2MPSLu7HDHTm8HiBsrDz
main holds the squashed #6 and #7, whose content this branch already contains, so the merge keeps the content of this branch as it is. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Hc2MPSLu7HDHTm8HiBsrDz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The client created an HTTP client of its own that nobody could configure: no timeout for connecting, no proxy, no TLS. An unreachable server, e.g. behind a firewall that drops packets, left a request waiting for the timeout of the operating system.
What changes:
new Client(baseUrl, apiToken, options)takesClientOptions, a record withwithmethods like the options for reading and observing.withHttpClienthands over ajava.net.http.HttpClientconfigured by the caller.Part of the series on the API before the first release. Builds on #7.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Hc2MPSLu7HDHTm8HiBsrDz