You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
temporal server start-dev now prints a Persistence: line at the end of the startup banner.
In-memory (no --db-filename):
Persistence: in-memory (Workflow Executions are lost when the server process exits)
File-backed:
Persistence: file (/path/to/dev.sqlite)
Why?
Per #634, the start-dev banner did not surface what form of persistence the dev server uses, so users could not tell at a glance whether Workflow Executions would survive a restart.
Two new tests in internal/temporalcli/commands.server_test.go start the dev server, capture stdout, and assert that the banner contains Persistence: plus the expected backend description. Both pass locally and fail when the banner change is reverted.
$ go test -run TestServer_StartDev_BannerPersistence ./internal/temporalcli/
ok github.com/temporalio/cli/internal/temporalcli 10.318s
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You have signed the CLA already but the status is still pending? Let us recheck it.
Label prefix: The other banner entries all use a Temporal prefix (Temporal Server:, Temporal UI:, etc.) — Persistence: should follow suit and become Temporal Persistence:.
Placement: Move the persistence line between Temporal Server: and Temporal UI: so it's grouped with server-level info rather than appended at the end.
Drop the warning text: The in-memory description (Workflow Executions are lost when the server process exits) is likely to alarm users unnecessarily. Just in-memory is enough — users can look up what that means, and it's already well-understood.
Column width: With Temporal Persistence: being 21 chars, bump the format width from %-17s to %-21s across all lines to keep alignment.
Applied all four banner suggestions in 2b09ade: Temporal Persistence: label, moved between Server and UI, dropped the in-memory warning text, and bumped width to %-21s across all lines. Updated the test assertions to match. CLA still pending on my side.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
temporal server start-devnow prints aPersistence:line at the end of the startup banner.In-memory (no
--db-filename):File-backed:
Why?
Per #634, the start-dev banner did not surface what form of persistence the dev server uses, so users could not tell at a glance whether Workflow Executions would survive a restart.
Checklist
Closes [Feature Request] Add persistence information to
start-devbanner #634How was this tested:
Two new tests in
internal/temporalcli/commands.server_test.gostart the dev server, capture stdout, and assert that the banner containsPersistence:plus the expected backend description. Both pass locally and fail when the banner change is reverted.