Skip to content

Add persistence info to start-dev banner#1033

Open
SAY-5 wants to merge 3 commits into
temporalio:mainfrom
SAY-5:feat/start-dev-banner-persistence
Open

Add persistence info to start-dev banner#1033
SAY-5 wants to merge 3 commits into
temporalio:mainfrom
SAY-5:feat/start-dev-banner-persistence

Conversation

@SAY-5
Copy link
Copy Markdown

@SAY-5 SAY-5 commented May 21, 2026

What was changed

temporal server start-dev now prints a Persistence: line at the end of the startup banner.

In-memory (no --db-filename):

Persistence:      in-memory (Workflow Executions are lost when the server process exits)

File-backed:

Persistence:      file (/path/to/dev.sqlite)

Why?

Per #634, the start-dev banner did not surface what form of persistence the dev server uses, so users could not tell at a glance whether Workflow Executions would survive a restart.

Checklist

  1. Closes [Feature Request] Add persistence information to start-dev banner #634

  2. How was this tested:

Two new tests in internal/temporalcli/commands.server_test.go start the dev server, capture stdout, and assert that the banner contains Persistence: plus the expected backend description. Both pass locally and fail when the banner change is reverted.

$ go test -run TestServer_StartDev_BannerPersistence ./internal/temporalcli/
ok  	github.com/temporalio/cli/internal/temporalcli	10.318s

@SAY-5 SAY-5 requested a review from a team as a code owner May 21, 2026 08:37
@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@chaptersix chaptersix self-requested a review May 21, 2026 23:00
@chaptersix
Copy link
Copy Markdown
Contributor

A few suggestions on the banner format:

  1. Label prefix: The other banner entries all use a Temporal prefix (Temporal Server:, Temporal UI:, etc.) — Persistence: should follow suit and become Temporal Persistence:.

  2. Placement: Move the persistence line between Temporal Server: and Temporal UI: so it's grouped with server-level info rather than appended at the end.

  3. Drop the warning text: The in-memory description (Workflow Executions are lost when the server process exits) is likely to alarm users unnecessarily. Just in-memory is enough — users can look up what that means, and it's already well-understood.

  4. Column width: With Temporal Persistence: being 21 chars, bump the format width from %-17s to %-21s across all lines to keep alignment.

Suggested output:

Temporal CLI 0.0.0-DEV (Server 1.31.0, UI 2.49.1)

Temporal Server:      localhost:7233
Temporal Persistence: in-memory
Temporal UI:          http://localhost:8233
Temporal Metrics:     http://localhost:61114/metrics

And for file-backed:

Temporal Persistence: /path/to/dev.sqlite

@chaptersix
Copy link
Copy Markdown
Contributor

Please make sure you have signed the Temporal CLA before this can be merged.

@SAY-5
Copy link
Copy Markdown
Author

SAY-5 commented May 22, 2026

Applied all four banner suggestions in 2b09ade: Temporal Persistence: label, moved between Server and UI, dropped the in-memory warning text, and bumped width to %-21s across all lines. Updated the test assertions to match. CLA still pending on my side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Add persistence information to start-dev banner

3 participants