[RELEASE] fix: active nav state via direct DOM (bypasses broken prop chain)#3309
Merged
Conversation
…roken prop chain) The shared SideBar component's isActive prop chain wasn't reliably setting the active state on cloud's routes. This bypasses it entirely: Layout runs a useEffect that queries the DOM for sidebar links, matches hrefs against window.location.pathname, and adds a visible .cloud-nav-active class. GUARANTEED to work — no React prop chain, no data-attributes, no shared component internals. Just direct DOM + CSS.
tangletools
approved these changes
Jun 25, 2026
tangletools
left a comment
tangletools
left a comment
Contributor
There was a problem hiding this comment.
✅ Auto-approved PR — b1b9f0bb
Blanket team auto-approval is enabled for this reviewer service.
The full PR reviewer audit still runs separately and will publish findings if it detects issues.
tangletools · auto-approval · reason: blanket_auto_approve · 2026-06-25T00:00:39Z
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Direct DOM injection in Layout useEffect — marks active sidebar item by matching URL pathname. Guaranteed visible. CSS: indigo bg + white text + left border.