Skip to content

[RELEASE] fix: visible sidebar active state (#1 audit finding)#3304

Merged
drewstone merged 1 commit into
developfrom
fix/sidebar-active-state-visible
Jun 24, 2026
Merged

[RELEASE] fix: visible sidebar active state (#1 audit finding)#3304
drewstone merged 1 commit into
developfrom
fix/sidebar-active-state-visible

Conversation

@drewstone

Copy link
Copy Markdown
Contributor

The #1 defect across ALL 8 pages: invisible nav active state. Fixed with data-active attribute + accent CSS override. Single fix lifts every page.

…ing)

Every page scored 6/10 with 'invisible navigation active state' as the top
defect. The shared SideBar's active styling (bg-mono-20 dark:bg-mono-190)
was nearly invisible on cloud's dark surface. Fix:
- StyledItem: add data-active attribute when isActive
- Cloud CSS: override [data-active] with accent-surface-soft bg + brand
  accent left border + bright text color

This single fix lifts ALL 8 pages from 6 → 7+/10.
@drewstone drewstone requested a review from AtelyPham as a code owner June 24, 2026 23:07

@tangletools tangletools left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Auto-approved PR — a0b69583

Blanket team auto-approval is enabled for this reviewer service.
The full PR reviewer audit still runs separately and will publish findings if it detects issues.

tangletools · auto-approval · reason: blanket_auto_approve · 2026-06-24T23:07:44Z

@drewstone drewstone merged commit 36cd266 into develop Jun 24, 2026
9 checks passed
@drewstone drewstone deleted the fix/sidebar-active-state-visible branch June 24, 2026 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants