Skip to content

rc/8.0.0#216

Merged
tompsota merged 23 commits into
masterfrom
rc/7.6.0
Jun 1, 2026
Merged

rc/8.0.0#216
tompsota merged 23 commits into
masterfrom
rc/7.6.0

Conversation

@martinzigrai
Copy link
Copy Markdown
Contributor

@martinzigrai martinzigrai commented May 7, 2026

No description provided.

tompsota
tompsota requested changes May 13, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@tompsota tompsota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more thing: There are no tests for SuspiciousAppDetectionConfig, MalwareScanScope, ScopeType, or ReasonMode. Every other model in lib/src/models/ has a corresponding test/src/models/*_test.dart covering construction, toJson, fromJson, and edge cases (see test/src/models/android_config_test.dart lines 45–91 for the established pattern).

Also missing: an AndroidConfig test exercising the suspiciousAppDetectionConfig field in both fromJson/toJson directions

Can you just generate some simple test cases?

If the requested changes here are relevant also for other repos, please update those as well.

Comment thread example/lib/main.dart Outdated
Comment thread CHANGELOG.md Outdated
Comment thread lib/src/models/android_config.dart Outdated
Comment thread lib/src/models/android_config.g.dart
Comment thread android/src/main/kotlin/com/aheaditec/freerasp/Extensions.kt Outdated
Comment thread android/src/main/kotlin/com/aheaditec/freerasp/Extensions.kt Outdated
Comment thread android/src/main/kotlin/com/aheaditec/freerasp/Extensions.kt Outdated
Comment thread lib/src/models/suspicious_app_detection_config.dart
tompsota
tompsota requested changes May 13, 2026
View reviewed changes
Comment thread android/src/main/kotlin/com/aheaditec/freerasp/Extensions.kt Outdated
Comment thread android/src/main/kotlin/com/aheaditec/freerasp/Extensions.kt Outdated
@martinzigrai
Copy link
Copy Markdown
Contributor Author

martinzigrai commented May 13, 2026

Added tests for SuspiciousAppDetectionConfig, MalwareScanScope, ScopeType, ReasonMode plus AndroidConfig coverage for the suspiciousAppDetectionConfig field.

@martinzigrai martinzigrai changed the title Rc/7.6.0 rc/8.0.0 May 13, 2026
tompsota
tompsota requested changes May 18, 2026
View reviewed changes
Comment thread example/lib/main.dart Outdated
martinzigrai and others added 3 commits May 18, 2026 18:20
@martinzigrai
refactor: rename MalwareScanScope to ScanScope and malwareScanScope f…
11f8e45 
…ield to scanScope
@martinzigrai
fix: unify API with other platforms
3958139
@tompsota @cursoragent
refactor: rename ScanScope.scanScope field to scopeType
b22631f 
Rename the `scanScope: ScopeType` field inside the `ScanScope` class to
`scopeType` so the field name matches its type name. Update the generated
g.dart, JSON key, default config, example app, Kotlin native bridge, and
all tests accordingly.

Co-authored-by: Cursor <cursoragent@cursor.com>
@tompsota tompsota added the release Create a new release on GH and publish package label May 28, 2026
@tompsota tompsota merged commit 11f2fa4 into master Jun 1, 2026
4 checks passed
@tompsota tompsota deleted the rc/7.6.0 branch June 1, 2026 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tompsota tompsota tompsota approved these changes

Assignees

No one assigned

Labels

release Create a new release on GH and publish package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@martinzigrai @tompsota