notifyicon.go: remove the WM_LBUTTONUP handler in favor of NIN_SELECT#141
Merged
Conversation
NIN_SELECT was added in Windows 2000 and is sent along with WM_LBUTTONUP. We added support for NIN_SELECT in 6376def, but left WM_LBUTTONUP unchanged, closing the context menu as soon as it's opened by left-click and causing MouseUp handlers to run twice. Updates tailscale/corp#44417 Updates tailscale/corp#38195 Signed-off-by: Nick Khyl <nickk@tailscale.com>
nickkhyl
commented
Jul 2, 2026
| // Creating the window with WS_DISABLED in an effort to dissuade screen | ||
| // readers from treating the hidden window as focusable content. | ||
| Style: win.WS_OVERLAPPEDWINDOW | win.WS_DISABLED, | ||
| Style: win.WS_OVERLAPPEDWINDOW | win.WS_DISABLED, |
Member
Author
There was a problem hiding this comment.
I didn't really touch this, but it looks like the previous commit wasn't formatted with go fmt.
Member
Author
|
Oh, right. I remember #140, but the commit message doesn't say anything about fixing a regression, and I missed that it also removes the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NIN_SELECTwas added in Windows 2000 and is sent along withWM_LBUTTONUP. We added support forNIN_SELECTin 6376def, but leftWM_LBUTTONUPunchanged, closing the context menu as soon as it's opened by left-click and causingMouseUphandlers to run twice.Updates tailscale/corp#44417
Updates tailscale/corp#38195