Repository navigation
Conversation
The two WIF entries added by tableau#1887 and tableau#1894 were ~34 and ~56 lines; every other entry in the file is 2-9 lines. Compressed both to ~13 lines each, keeping the headline capability, the key constraints (server version, auth, side-effects), and the gotchas callers must know (reject non-UUID; resend `workgroup_auth_mode`); moved the full method-by-method surface area to the API docs on gh-pages where it belongs. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
- Entry 2: restore the "server does not echo WIF attributes on GET today" caveat. Without it a round-trip write-then-read silently returns None, with no error signal to tell the caller why. - Entry 1: distinguish "WIF feature not available on the site" (403 across the board) from "admin has not yet called enable()" (config/connector operations return 404; get() returns a shell). Prior wording collapsed both into "WIF is not enabled" which conflicts with the enable() method name. - Entry 1: restore the NO_ACCESS caveat for key-management methods (connected-app JWT sessions return 401; use a PAT or password session for key rotation). - Standardize "available / enabled" wording across both entries. Entries now land at 14 lines each — still within the house range (urllib3 / redirects / CSVImport neighbors run 6–9 lines). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
bcantoni
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Review comment on #1887 and #1894: the WIF entries I added to
CHANGELOG.mdran ~34 and ~56 lines, while every other entry in the file is 2–9 lines. Shortening both to ~13 lines each so they match the shape of the surrounding entries (urllib3 bump, redirect preservation, CSVImport fix).What I kept:
workgroup_auth_modeon later updates.What I dropped:
server.auth_federation.*endpoints — covered by the API docs ongh-pages(PR @W-24145098 - docs: document WIF admin REST API endpoints #1895).Net:
+20 / -82.🤖 Generated with Claude Code