Skip to content

Fixed hyperlinks throughout README to point to desired sites - #118

Closed
cookjosh wants to merge 1 commit into
swaroopch:masterfrom
cookjosh:master
Closed

cookjosh wants to merge 1 commit into
swaroopch:masterfrom
cookjosh:master

Conversation

@cookjosh

Copy link
Copy Markdown

This is my first attempt at forking and creating a pull request! I was unsure what links you intended or where you were trying to draw values in from, but for me, the links all showed something like {{ book.officialUrl }} or something like that.

Hope it's helpful!

@bakoontz

bakoontz commented Aug 9, 2024

Copy link
Copy Markdown

I think the perceived problem is that the "broken links" are actually used by honkit to generate the web version. You can see the links are correctly rendered if you look here: https://python.swaroopch.com/

Copy link
Copy Markdown
Owner

Thanks for your first contribution! These placeholders are resolved when the book is built. The GitHub README does need a separate solution, but these replacements introduce some incorrect destinations, so I’m closing this approach.

@swaroopch swaroopch closed this Sep 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants