Skip to content

🇨🇳(i18n) rename cn_CN to zh_CN, add eo_PL and zh_TW locales#2486

Open
exyone-js wants to merge 1 commit into
suitenumerique:mainfrom
exyone-js:main
Open

🇨🇳(i18n) rename cn_CN to zh_CN, add eo_PL and zh_TW locales#2486
exyone-js wants to merge 1 commit into
suitenumerique:mainfrom
exyone-js:main

Conversation

@exyone-js

Copy link
Copy Markdown

i18n: fix zh locale codes and add Esperanto

  • Rename cn-CNzh-CN (correct BCP 47 language code)
  • Introduce zh-TW for Traditional Chinese (Taiwan conventions)
  • Add Esperanto (eo)
    • No ISO country exists for Esperanto
    • Creator Zamenhof was Polish → use eo-PL as a placeholder
    • Analogous to la-IT for Latin
  • Region tags are administrative, not linguistic variants

@coderabbitai

coderabbitai Bot commented Jul 1, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

This pull request updates Django gettext translation catalogs across multiple locale directories. It adds a new Esperanto (eo_PL) translation file, adds a new Traditional Chinese (zh_TW) translation file, updates existing Simplified Chinese (zh_CN) translations replacing Traditional Chinese text and filling previously empty entries, and removes all content from the Simplified Chinese (cn_CN) translation file. No source code logic or public API declarations are altered.

Estimated code review effort: 2 (Simple) | ~10 minutes

Changes

Cohort / File(s) Summary
eo_PL translations (src/backend/locale/eo_PL/LC_MESSAGES/django.po) New file adding Esperanto translations for admin, API, model, and email template strings
zh_TW translations (src/backend/locale/zh_TW/LC_MESSAGES/django.po) New file adding Traditional Chinese translations for admin, API, model, and email template strings
zh_CN translations (src/backend/locale/zh_CN/LC_MESSAGES/django.po) Replaces Traditional Chinese text with Simplified Chinese and fills previously empty translations
cn_CN translations (src/backend/locale/cn_CN/LC_MESSAGES/django.po) Removes all previously defined translation entries

Related PRs: None identified from the provided context.

Suggested labels: translations, i18n

Suggested reviewers: None identified from the provided context.

Poem

A rabbit hops through locale trees,
Esperanto whispers on the breeze,
Chinese scripts both old and new,
Simplified now shines on through,
One empty file left bare and free —
Translations dance, one, two, three! 🐇🌐

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the main change: locale code fixes and adding Esperanto and Traditional Chinese locales.
Description check ✅ Passed The description is directly related to the locale/i18n changes in the pull request.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/backend/locale/eo_PL/LC_MESSAGES/django.po`:
- Around line 44-46: The translation for the “Tree structure” msgid in the eo_PL
django.po catalog uses a misleading forest-related phrase. Update the msgstr for
that entry to a tree-specific Esperanto term such as Arbostrukturo or arba
strukturo, keeping the existing msgid unchanged and making sure the locale entry
in the gettext catalog matches the UI label used by core/admin.py.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: e26af987-ce0a-450b-8310-9f00b06d713a

📥 Commits

Reviewing files that changed from the base of the PR and between 6ec541f and 78aea72.

📒 Files selected for processing (4)
  • src/backend/locale/cn_CN/LC_MESSAGES/django.po
  • src/backend/locale/eo_PL/LC_MESSAGES/django.po
  • src/backend/locale/zh_CN/LC_MESSAGES/django.po
  • src/backend/locale/zh_TW/LC_MESSAGES/django.po
💤 Files with no reviewable changes (1)
  • src/backend/locale/cn_CN/LC_MESSAGES/django.po

Comment on lines +44 to +46
#: core/admin.py:200
msgid "Tree structure"
msgstr "Arbara strukturo"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Use a tree-specific Esperanto term here.

Arbara strukturo reads as “forest structure”, which is misleading for this tree widget label. Arbostrukturo or arba strukturo would fit better.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/backend/locale/eo_PL/LC_MESSAGES/django.po` around lines 44 - 46, The
translation for the “Tree structure” msgid in the eo_PL django.po catalog uses a
misleading forest-related phrase. Update the msgstr for that entry to a
tree-specific Esperanto term such as Arbostrukturo or arba strukturo, keeping
the existing msgid unchanged and making sure the locale entry in the gettext
catalog matches the UI label used by core/admin.py.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant