Repository navigation
Fix flaky Test_validAuth in connect middleware - #21
Merged
Merged
Conversation
The test authenticator kept request header casing, so X-SUBSTREAMS-Ll and x-substreams-ll collided once WithTrustedHeaders lower-cased them and map iteration order picked the winner. Lower-case keys like real authenticators do, and switch to stretchr/testify assert.
UlysseCorbeil
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
X-SUBSTREAMS-Llandx-substreams-llboth ended up in the map.WithTrustedHeaderslower-cases every key, so the two collided and map iteration order decided which value won. The test failed about half the time.trust,secret,grpc) do.stretchr/testify/assertinstead oftest-go/testify, and the unusedtest-go/testifydependency is gone.