Repository navigation
Drop LIB from OneBlockFile.CanonicalName - #84
Merged
sduchesneau merged 1 commit intoOct 9, 2026
Merged
sduchesneau merged 1 commit into
sduchesneau merged 1 commit into
Conversation
Readers with a different view of the LIB write the same block with different LIB numbers in the one-block filename. Including the LIB in CanonicalName made those copies look like different blocks, so the merger moved canonical copies to the forked-blocks store. See streamingfast/firehose-core#282 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
YaroShkvorets
added a commit
to YaroShkvorets/firehose-core
that referenced
this pull request
Oct 9, 2026
Drop the merger's own block-ID key now that bstream's CanonicalName no longer includes the LIB (streamingfast/bstream#84). Needs the bstream bump. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
sduchesneau
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop the LIB from
OneBlockFile.CanonicalName(num-id-prevID), so copies of the same block written by readers with a different LIB view are the same block.Needed for streamingfast/firehose-core#283 (fixes streamingfast/firehose-core#282).
🤖 Generated with Claude Code