feat: add new featored blog field - #77
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
fonodi
approved these changes
Jul 30, 2026
fonodi
left a comment
fonodi
left a comment
Collaborator
There was a problem hiding this comment.
Looking good, good job 👍
|
|
||
| const remainingPosts = featuredPost | ||
| ? posts.filter((post) => post.documentId !== featuredPost.documentId) | ||
| : [...posts] |
Collaborator
There was a problem hiding this comment.
nit: I'm not sure you need to spread the posts into an array, if they are already an array.
Collaborator
Author
There was a problem hiding this comment.
its just a typescript thing - posts are a readonly type (returned from the api) but remainingPosts is returned as a mutable array
it would probably be ok if i suppressed this type error but i think its safer to leave it this way
Collaborator
There was a problem hiding this comment.
No, it's the right call then, thank you 🙏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task Link
Task #
Description
Adds a featuredBlogPost relation on the Blog single type. The blog index uses that pick for the hero (falling back to the newest post when unset) and keeps the pinned post out of the list / Load More so it doesn’t appear twice.
New environmental variables
If your PR introduces new environment variables, please list them here along with a description of their use and apply the
requires-env-varslabel.Checklist - author
requires-env-varswhen PR requires environmental variablesready-for-reviewwhen PR is ready to be looked atready-to-mergewhen PR has a passing reviewneeds-revisionswhen PR has comments that block mergedo-not-reviewwhen PR is daft only and you don't want to get a reviewBefore merging
Checklist - reviewer