fix: allow passing MFA tickets when changing an account's email address - #179
Merged
Conversation
This commit adds an `MFATicket` parameter to the `AccountCollection.changeEmail`, which the backend mandates when the account has MFA enabled. The client still has to manually check whether passing a ticket is necessary by using `MFA.authenticatorEnabled`. Signed-off-by: Gabriel Gutiérrez Fuentes <me@gab.gf>
There was a problem hiding this comment.
Pull request overview
This PR updates AccountCollection.changeEmail() to support MFA-enabled accounts by allowing callers to provide an MFA ticket that is sent to the backend via the X-MFA-Ticket header.
Changes:
- Extend
AccountCollection.changeEmail()to accept an optionalMFATicketparameter. - Consume the MFA ticket before making the request and conditionally attach
X-MFA-Ticketto the API call.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Gabriel Gutiérrez Fuentes <me@gab.gf>
9 tasks
Dadadah
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an optional
MFATicketparameter toAccountCollection.changeEmail().Currently, accounts with MFA enabled fail when trying to change their email address because the backend endpoint mandates a verified ticket, but the SDK didn't expose any way to pass one (unlike
Session.delete()).Fixes #178