Skip to content

style: add spaces - #15129

Merged
kgryte merged 2 commits into
developfrom
philipp/fix-commit-review-2026-09-09
Sep 10, 2026
Merged

style: add spaces#15129
kgryte merged 2 commits into
developfrom
philipp/fix-commit-review-2026-09-09

Conversation

@Planeshifter

Copy link
Copy Markdown
Member

Description

What is the purpose of this pull request?

Follow-up fixes for commits merged to develop between 2026-09-08 23:09 (-0700) (dec095d) and 2026-09-09 01:25 (-0500) (6298f5e).

This pull request:

stats/base/dists/bernoulli/cdf

  • Fix expected[i]expected[ i ] in test.factory.js (lines 136, 155), missed by 6f3dfa0's ULP migration and inconsistent with every other file in the batch; violates the "spaces around array indices" rule in the style guide.

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Validation

All 10 commits merged to develop in the review window were audited for:

  • stdlib style guide compliance (two independent passes against docs/style-guides, cross-checked against unmodified reference packages already using @stdlib/assert/is-almost-same-value)
  • bugs and incorrect logic in the introduced code (two independent passes; migrated test files were additionally executed to confirm all assertions pass at the new ULP tolerances)

Deliberately excluded: anything requiring interpretation or judgment (e.g., chosen ULP tolerances, require ordering, which varies among existing reference files, and "See Also" README ordering, which follows the established bot accumulation pattern rather than strict alphabetical order).

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

This PR was authored by Claude Code as part of a scheduled automated review of commits merged to develop in the preceding 24 hours; the fix was applied and verified by Claude Code.

🤖 Generated with Claude Code

https://claude.ai/code/session_01H1HVy6g25PpNnoamrmovE4


Generated by Claude Code

@stdlib-bot stdlib-bot added the Statistics Issue or pull request related to statistical functionality. label Sep 9, 2026
@stdlib-bot

stdlib-bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/bernoulli/cdf $\\color{green}283/283$
$\\color{green}+0.00\\%$
$\\color{green}27/27$
$\\color{green}+0.00\\%$
$\\color{green}4/4$
$\\color{green}+0.00\\%$
$\\color{green}283/283$
$\\color{green}+0.00\\%$

The above coverage report was generated for the changes in this PR.

Comment thread lib/node_modules/@stdlib/stats/base/dists/bernoulli/cdf/test/test.factory.js Outdated
Comment thread lib/node_modules/@stdlib/stats/base/dists/bernoulli/cdf/test/test.factory.js Outdated
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte
kgryte marked this pull request as ready for review September 10, 2026 03:33
@kgryte
kgryte requested a review from a team September 10, 2026 03:33
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Sep 10, 2026
@kgryte kgryte changed the title style: add spaces around array indices in stats/base/dists/bernoulli/cdf style: add spaces Sep 10, 2026
@kgryte
kgryte merged commit 6d0ed9a into develop Sep 10, 2026
30 checks passed
@kgryte
kgryte deleted the philipp/fix-commit-review-2026-09-09 branch September 10, 2026 04:35
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Sep 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants