Skip to content

refactor: align ndarray/base/diagonal error message and remove namespace self-refs #12096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kgryte merged 4 commits into from
May 11, 2026
Merged

refactor: align ndarray/base/diagonal error message and remove namespace self-refs #12096

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
03cc53f
refactor: align `ndarray/base/diagonal` error message with sibling
claude May 11, 2026
fd98ecb
chore: remove self-references from `namespace` related arrays
claude May 11, 2026
2169fff
Apply suggestions from code review
kgryte May 11, 2026
7a84165
Apply suggestions from code review
kgryte May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/node_modules/@stdlib/namespace/lib/namespace/base/a.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@
});

ns.push({
'alias': 'base.absf',

Check warning on line 77 in lib/node_modules/@stdlib/namespace/lib/namespace/base/a.js

View workflow job for this annotation

GitHub Actions / Lint Changed Files 

Unknown word: "absf"
'path': '@stdlib/math/base/special/absf',
'value': require( '@stdlib/math/base/special/absf' ),
'type': 'Function',
Expand All @@ -86,7 +86,7 @@
});

ns.push({
'alias': 'base.acartesianPower',

Check warning on line 89 in lib/node_modules/@stdlib/namespace/lib/namespace/base/a.js

View workflow job for this annotation

GitHub Actions / Lint Changed Files 

Unknown word: "acartesian"
'path': '@stdlib/array/base/cartesian-power',
'value': require( '@stdlib/array/base/cartesian-power' ),
'type': 'Function',
Expand All @@ -98,7 +98,7 @@
});

ns.push({
'alias': 'base.acartesianProduct',

Check warning on line 101 in lib/node_modules/@stdlib/namespace/lib/namespace/base/a.js

View workflow job for this annotation

GitHub Actions / Lint Changed Files 

Unknown word: "acartesian"
'path': '@stdlib/array/base/cartesian-product',
'value': require( '@stdlib/array/base/cartesian-product' ),
'type': 'Function',
Expand All @@ -110,7 +110,7 @@
});

ns.push({
'alias': 'base.acartesianSquare',

Check warning on line 113 in lib/node_modules/@stdlib/namespace/lib/namespace/base/a.js

View workflow job for this annotation

GitHub Actions / Lint Changed Files 

Unknown word: "acartesian"
'path': '@stdlib/array/base/cartesian-square',
'value': require( '@stdlib/array/base/cartesian-square' ),
'type': 'Function',
Expand All @@ -134,7 +134,7 @@
});

ns.push({
'alias': 'base.acosd',

Check warning on line 137 in lib/node_modules/@stdlib/namespace/lib/namespace/base/a.js

View workflow job for this annotation

GitHub Actions / Lint Changed Files 

Unknown word: "acosd"
'path': '@stdlib/math/base/special/acosd',
'value': require( '@stdlib/math/base/special/acosd' ),
'type': 'Function',
Expand All @@ -148,7 +148,7 @@
});

ns.push({
'alias': 'base.acosdf',

Check warning on line 151 in lib/node_modules/@stdlib/namespace/lib/namespace/base/a.js

View workflow job for this annotation

GitHub Actions / Lint Changed Files 

Unknown word: "acosdf"
'path': '@stdlib/math/base/special/acosdf',
'value': require( '@stdlib/math/base/special/acosdf' ),
'type': 'Function',
Expand All @@ -162,7 +162,7 @@
});

ns.push({
'alias': 'base.acosf',

Check warning on line 165 in lib/node_modules/@stdlib/namespace/lib/namespace/base/a.js

View workflow job for this annotation

GitHub Actions / Lint Changed Files 

Unknown word: "acosf"
'path': '@stdlib/math/base/special/acosf',
'value': require( '@stdlib/math/base/special/acosf' ),
'type': 'Function',
Expand All @@ -187,7 +187,7 @@
});

ns.push({
'alias': 'base.acot',

Check warning on line 190 in lib/node_modules/@stdlib/namespace/lib/namespace/base/a.js

View workflow job for this annotation

GitHub Actions / Lint Changed Files 

Unknown word: "acot"
'path': '@stdlib/math/base/special/acot',
'value': require( '@stdlib/math/base/special/acot' ),
'type': 'Function',
Expand All @@ -199,7 +199,7 @@
});

ns.push({
'alias': 'base.acotd',

Check warning on line 202 in lib/node_modules/@stdlib/namespace/lib/namespace/base/a.js

View workflow job for this annotation

GitHub Actions / Lint Changed Files 

Unknown word: "acotd"
'path': '@stdlib/math/base/special/acotd',
'value': require( '@stdlib/math/base/special/acotd' ),
'type': 'Function',
Expand All @@ -213,7 +213,7 @@
});

ns.push({
'alias': 'base.acotdf',

Check warning on line 216 in lib/node_modules/@stdlib/namespace/lib/namespace/base/a.js

View workflow job for this annotation

GitHub Actions / Lint Changed Files 

Unknown word: "acotdf"
'path': '@stdlib/math/base/special/acotdf',
'value': require( '@stdlib/math/base/special/acotdf' ),
'type': 'Function',
Expand Down Expand Up @@ -942,7 +942,7 @@
'related': [
'@stdlib/math/base/special/acosh',
'@stdlib/math/base/special/asec',
'@stdlib/math/base/special/asech',
'@stdlib/math/base/special/asechf',
'@stdlib/math/base/special/acoth',
Comment thread
kgryte marked this conversation as resolved.
'@stdlib/math/base/special/sech'
]
Expand Down
1 change: 0 additions & 1 deletion lib/node_modules/@stdlib/namespace/lib/namespace/base/strided/d.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -796,7 +796,6 @@ ns.push({
'type': 'Function',
'related': [
'@stdlib/math/strided/special/ddeg2rad',
'@stdlib/math/strided/special/dmskdeg2rad',
'@stdlib/math/strided/special/mskrad2deg',
'@stdlib/math/strided/special/smskdeg2rad'
]
Expand Down
2 changes: 1 addition & 1 deletion lib/node_modules/@stdlib/namespace/lib/namespace/base/strided/u.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ ns.push({
'value': require( '@stdlib/strided/base/unary' ),
'type': 'Function',
'related': [
'@stdlib/strided/base/unary',
'@stdlib/strided/base/binary',
'@stdlib/strided/base/dmap',
Comment thread
kgryte marked this conversation as resolved.
'@stdlib/strided/base/nullary',
'@stdlib/strided/base/quaternary',
Expand Down
2 changes: 1 addition & 1 deletion lib/node_modules/@stdlib/namespace/lib/namespace/i.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5778,7 +5778,7 @@ ns.push({
'type': 'Function',
'related': [
'@stdlib/math/iter/ops/add',
'@stdlib/math/iter/ops/divide',
'@stdlib/math/iter/ops/subtract',
'@stdlib/math/iter/ops/multiply'
Comment thread
kgryte marked this conversation as resolved.
]
});
Expand Down
4 changes: 2 additions & 2 deletions lib/node_modules/@stdlib/ndarray/base/diagonal/lib/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ var format = require( '@stdlib/string/format' );
* @param {integer} k - diagonal offset
* @param {boolean} writable - boolean indicating whether the returned ndarray should be writable
* @throws {RangeError} must provide exactly two dimension indices
* @throws {RangeError} input ndarray must have at least two dimensions
* @throws {RangeError} must provide an ndarray having two or more dimensions
* @throws {RangeError} must provide valid dimension indices
* @throws {Error} must provide unique dimension indices
* @returns {ndarray} ndarray view
Expand Down Expand Up @@ -87,7 +87,7 @@ function diagonal( x, dims, k, writable ) {
sh = getShape( x );
ndims = sh.length;
if ( ndims < 2 ) {
throw new RangeError( format( 'invalid argument. First argument must be an ndarray having at least two dimensions. Number of dimensions: %d.', ndims ) );
throw new RangeError( format( 'invalid argument. First argument must be an ndarray having two or more dimensions. Number of dimensions: %d.', ndims ) );
}
st = getStrides( x );

Expand Down