[6.x] Fix Livewire CSRF script error when livewireScriptConfig is undefined - #15483
Open
joshuablum wants to merge 1 commit into
Open
joshuablum wants to merge 1 commit into
joshuablum wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a JS error thrown by the full measure static caching CSRF replacement script on standard Livewire 3 setups.
#13403 added a
livewire:initlistener for when the/!/csrfrequest resolves before Livewire has started. The listener setswindow.livewireScriptConfig.csrf, butlivewireScriptConfigonly exists when Livewire is bundled manually through@livewireScriptConfig. With@livewireScriptsor auto-injection, Livewire puts the token in thedata-csrfattribute on its script tag and never defineslivewireScriptConfig. The listener then throws:The error only shows up when the CSRF request finishes before Livewire starts, so it appears intermittently. Livewire keeps working, because it reads the token from
data-csrfon every request and the script already replaces that attribute. The error still ends up in the console and in error trackers.The listener now only sets the token when
livewireScriptConfigexists. Behaviour for manually bundled Livewire stays as it was.