Avoid env-var-secret false positives for SECRETS_* names

[arpitjain099]

Fixes #1198.

The built-in env-var-secret check used (?i).*secret.*, which also matched names like SECRETS_DIR.

This narrows the built-in pattern so plural secrets suffixes are not flagged, and extends the fixture with a SECRETS_DIR case to keep that behavior covered.

Verification:

• go test ./pkg/builtinchecks/...
• go run ./cmd/kube-linter lint --include env-var-secret --do-not-auto-add-defaults --format json tests/checks/env-var-secret.yml

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: 48646998-9713-495f-9b13-03aa1f1c28cb

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 30.71%. Comparing base (dbd7529) to head (20df834).
⚠️ Report is 341 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #1206       +/-   ##
===========================================
- Coverage   62.36%   30.71%   -31.65%     
===========================================
  Files         197      239       +42     
  Lines        4854     6534     +1680     
===========================================
- Hits         3027     2007     -1020     
- Misses       1439     4351     +2912     
+ Partials      388      176      -212     

Flag	Coverage Δ
unit	30.71% <ø> (-31.65%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[manuel-lang]

@arpitjain099 @rhybrillou Thanks a lot for implementing the changes and reviewing the PR. Is there anything more that is needed to get the PR merged? Can't wait to have this change available :)

[arpitjain099]

@rhybrillou @manuel-lang the approval here goes back to early July and the thread has gone quiet since. Is there anything outstanding on my side, or is this simply queued behind other work?