Skip to content

feat(iaas): image download - #1724

Open
j1n-o9r wants to merge 43 commits into
mainfrom
feat/STACKITTPR-771-remote-image-download
Open

feat(iaas): image download#1724
j1n-o9r wants to merge 43 commits into
mainfrom
feat/STACKITTPR-771-remote-image-download

Conversation

@j1n-o9r

@j1n-o9r j1n-o9r commented Aug 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

relates to STACKITTPR-771

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see examples/ directory)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Acceptance tests got implemented or updated (see e.g. here)
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@j1n-o9r
j1n-o9r force-pushed the feat/STACKITTPR-771-remote-image-download branch from 7dba5a7 to 60c955b Compare August 25, 2026 12:32
rubenhoenle
rubenhoenle reviewed Aug 25, 2026
View reviewed changes
Comment thread stackit/internal/services/iaas/image/resource.go Outdated
rubenhoenle
rubenhoenle reviewed Aug 25, 2026
View reviewed changes
Comment thread stackit/internal/services/iaas/image/resource.go Outdated
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it.

@github-actions github-actions Bot added the Stale PR is marked as stale due to inactivity. label Sep 8, 2026
@rubenhoenle rubenhoenle added ignore-stale and removed Stale PR is marked as stale due to inactivity. labels Sep 10, 2026
@j1n-o9r
j1n-o9r force-pushed the feat/STACKITTPR-771-remote-image-download branch from fbb728b to 24d01e0 Compare September 21, 2026 13:48
@j1n-o9r
j1n-o9r marked this pull request as ready for review September 29, 2026 07:59
@j1n-o9r
j1n-o9r requested a review from a team as a code owner September 29, 2026 07:59
@rubenhoenle

rubenhoenle commented Sep 30, 2026

Copy link
Copy Markdown
Member

@j1n-o9r Please resolve the comments you've addressed already

rubenhoenle
rubenhoenle reviewed Sep 30, 2026
View reviewed changes
Comment thread stackit/internal/services/iaas/image/resource.go
rubenhoenle
rubenhoenle reviewed Sep 30, 2026
View reviewed changes
Comment thread stackit/internal/services/iaas/image/resource.go Outdated
rubenhoenle
rubenhoenle reviewed Sep 30, 2026
View reviewed changes
Comment thread stackit/internal/services/iaas/image/resource.go Outdated
rubenhoenle
rubenhoenle reviewed Sep 30, 2026
View reviewed changes
Comment thread stackit/internal/services/iaas/image/resource.go
rubenhoenle
rubenhoenle reviewed Sep 30, 2026
View reviewed changes
Comment thread stackit/internal/services/iaas/image/resource.go Outdated
rubenhoenle
rubenhoenle reviewed Sep 30, 2026
View reviewed changes
Comment thread stackit/internal/services/iaas/image/resource.go Outdated
rubenhoenle
rubenhoenle reviewed Sep 30, 2026
View reviewed changes
Comment thread stackit/internal/services/iaas/image/resource.go Outdated
rubenhoenle
rubenhoenle reviewed Sep 30, 2026
View reviewed changes
Comment thread stackit/internal/services/iaas/image/resource.go
rubenhoenle
rubenhoenle reviewed Sep 30, 2026
View reviewed changes
Comment thread stackit/internal/services/iaas/image/resource.go Outdated
rubenhoenle
rubenhoenle reviewed Sep 30, 2026
View reviewed changes
Comment thread stackit/internal/services/iaas/image/resource.go Outdated
rubenhoenle
rubenhoenle reviewed Sep 30, 2026
View reviewed changes
Comment thread stackit/internal/services/iaas/image/resource.go
rubenhoenle
rubenhoenle reviewed Sep 30, 2026
View reviewed changes
Comment thread stackit/internal/services/iaas/image/resource_test.go Outdated
rubenhoenle
rubenhoenle reviewed Sep 30, 2026
View reviewed changes
Comment thread stackit/internal/services/iaas/image/resource_test.go Outdated
rubenhoenle
rubenhoenle reviewed Sep 30, 2026
View reviewed changes
Comment thread stackit/internal/services/iaas/image/resource_test.go Outdated
rubenhoenle
rubenhoenle reviewed Sep 30, 2026
View reviewed changes
Comment thread stackit/internal/services/iaas/image/resource_test.go Outdated
rubenhoenle
rubenhoenle reviewed Sep 30, 2026
View reviewed changes
Comment thread stackit/internal/services/iaas/testdata/resource-image-max.tf
rubenhoenle
rubenhoenle requested changes Sep 30, 2026
View reviewed changes

@rubenhoenle rubenhoenle left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need some work. Feel free to bring open questions to our jourfix 😅

Comment thread stackit/internal/services/iaas/testdata/resource-image-max.tf
Comment thread stackit/internal/services/iaas/testdata/resource-image-min.tf
Comment thread stackit/internal/services/iaas/iaas_test.go Outdated
Comment thread stackit/internal/validate/validate.go Outdated
Comment thread stackit/internal/validate/validate_test.go
@j1n-o9r j1n-o9r changed the title feat(iaas): remote image download feat(iaas): image download Oct 6, 2026
j1n-o9r added 16 commits October 20, 2026 17:01
@j1n-o9r
iaas/image: adapt acceptance test to use new image.image_file.local.f…
fc54ac1 
…ile_path attribute instead of image.local_file_path
@j1n-o9r
iaas/image: add tf unit tests in iaas_test.go. Test XOR Validator and…
d99b2a1 
… Dowload
@j1n-o9r
add docs
ab35cba
@j1n-o9r
cleanup
cc743ff
@j1n-o9r
cleanup
5ed8e7f
@j1n-o9r
adapt examples
a01b555
@j1n-o9r
add missing brace in examples/resources/stackit_image/resource.tf
28719ff
@j1n-o9r
switch deprecation message into attribute
9e787e3
@j1n-o9r
remove unnecessary assignment of default value
2d70f74
@j1n-o9r
made iaas/image.image_file.dowload experimental
953d52a
@j1n-o9r
add removal of tmp dir after image create
498b7f7
@j1n-o9r
move codeblock in iaas/image/resource.go Create for resolving the fil…
2d97035 
…ePath to dedicated function and implement unit tests. Also adapt unit test for download file
@j1n-o9r
add proper error handling to iaas/image/resource_test.go
d75d50b
@j1n-o9r
refactor cleanup of temp dir on exit in iaas/image/resource.go Create…
2544bb5 
… function after encountering major bug
@j1n-o9r
make linter happy
8318fbf
@j1n-o9r
add leftover from rebase
107f202
@j1n-o9r
j1n-o9r force-pushed the feat/STACKITTPR-771-remote-image-download branch from e098ed4 to 107f202 Compare October 20, 2026 15:19

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rubenhoenle rubenhoenle rubenhoenle requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

domain:IaaS ignore-stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@j1n-o9r @rubenhoenle