Valkey containers for Rocky 9 and Ubuntu Noble#2383
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request enables the building of Valkey and Valkey Sentinel containers for Rocky 9 and Ubuntu Noble. It adds the corresponding image tags to kolla-image-tags.yml, removes these images from the unbuildable list in pulp.yml, and includes a release note documenting the change. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| valkey: | ||
| rocky-9: 2025.1-rocky-9-20260618T122602 | ||
| ubuntu-noble: 2025.1-ubuntu-noble-20260618T122602 | ||
| valkey_sentinel: |
There was a problem hiding this comment.
Shouldn't we rather update kolla-image-tags.py so valkey matches also valkey_sentinel?
There was a problem hiding this comment.
That would just be setting it here? Currently it just matches how redis was setup.
We'd either need a new exception map/logic in kolla-images.py to be able to override what's in kolla-ansible, or changes in kolla-ansible made and backported to change the tag inheritance—second option is probably better but would be breaking upstream?
owenjones
force-pushed
the
valkey
branch
2 times, most recently
from
5ab1f6e to
173959a
Compare
To enable redis -> valkey migrations, we need valkey images buildable on OSes other than Rocky 10.
2 participants
To enable redis -> valkey migrations, we need valkey images buildable on OSes other than Rocky 10.