Rename a nested type named Builder to avoid a collision#3639
Merged
oldergod merged 2 commits intoJun 29, 2026
Conversation
Member
|
@eyupcanakman thank you! I've added a commit to be not rename anything when we don't need to. |
oldergod
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A message generates a nested
Builder, so a proto type that is itself namedBuildercollided with it and the generated code did not compile. Both generators now reserve the name through aNameAllocator, renaming the nested type toBuilder_. Existing output is unchanged.Fixes #593